From: Thomas Graf <tgraf@suug.ch>
To: Ranjit Manomohan <ranjitm@google.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
lizf@cn.fujitsu.com, kaber@trash.net, menage@google.com
Subject: Re: [PATCH] Traffic control cgroups subsystem
Date: Fri, 25 Jul 2008 01:45:53 +0200 [thread overview]
Message-ID: <20080724234553.GC20815@postel.suug.ch> (raw)
In-Reply-To: <Pine.LNX.4.64.0807221041210.1091@ranjit.corp.google.com>
* Ranjit Manomohan <ranjitm@google.com> 2008-07-22 10:44
> The implementation consists of two parts:
>
> 1) A resource controller (cgroup_tc) that is used to associate packets from
> a particular task belonging to a cgroup with a traffic control class id (
> tc_classid). This tc_classid is propagated to all sockets created by
> tasks
> in the cgroup and will be used for classifying packets at the link layer.
>
> 2) A modified traffic control classifier (cls_flow) that can classify
> packets
> based on the tc_classid field in the socket to specific destination
> classes.
>
> An example of the use of this resource controller would be to limit
> the traffic from all tasks from a file_server cgroup to 100Mbps. We could
> achieve this by doing:
>
> # make a cgroup of file transfer processes and assign it a uniqe classid
> # of 0x10 - this will be used lated to direct packets.
> mkdir -p /dev/cgroup
> mount -t cgroup tc -otc /dev/cgroup
> mkdir /dev/cgroup/file_transfer
> echo 0x10 > /dev/cgroup/file_transfer/tc.classid
> echo $PID_OF_FILE_XFER_PROCESS > /dev/cgroup/file_transfer/tasks
>
> # Now create a HTB class that rate limits traffic to 100mbits and attach
> # a filter to direct all traffic from cgroup file_transfer to this new
> class.
> tc qdisc add dev eth0 root handle 1: htb
> tc class add dev eth0 parent 1: classid 1:10 htb rate 100mbit ceil 100mbit
> tc filter add dev eth0 parent 1: handle 800 protocol ip prio 1 flow map key
> cgroup-classid baseclass 1:10
It might have been easier to simply write a classifier which maps pids
to classes. The interface could be as simple as two nested attributes,
ADD_MAPS, REMOVE_MAPS which both take lists of pid->class mappings to
either add or remove from the classifier.
I have been working on this over the past 2 weeks, it includes the
classifier as just stated, a cgroup module which sends notifications
about events as netlink messages and a daemon which creates qdiscs,
classes and filters on the fly according to the configured distribution.
It works both ingress (with some tricks) and egress.
IMHO, there is no point in a cgroup interface if the user has to create
qdiscs, classes and filters manually anyway.
next prev parent reply other threads:[~2008-07-24 23:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-22 17:44 [PATCH] Traffic control cgroups subsystem Ranjit Manomohan
2008-07-23 22:05 ` Andrew Morton
2008-07-23 22:34 ` Patrick McHardy
2008-07-23 23:54 ` Ranjit Manomohan
2008-07-24 0:17 ` Patrick McHardy
2008-07-24 23:45 ` Thomas Graf [this message]
2008-07-25 1:16 ` Ranjit Manomohan
2008-07-25 9:29 ` Thomas Graf
2008-07-25 1:18 ` Paul Menage
-- strict thread matches above, loose matches on Subject: below --
2008-07-22 4:08 Ranjit Manomohan
2008-07-22 10:35 ` Patrick McHardy
2008-07-22 12:14 ` Paul Menage
2008-07-22 12:48 ` Patrick McHardy
2008-07-22 12:56 ` Paul Menage
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080724234553.GC20815@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
--cc=netdev@vger.kernel.org \
--cc=ranjitm@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).