From: David Miller <davem@davemloft.net>
To: jarkao2@gmail.com
Cc: jussi.kivilinna@mbnet.fi, kaber@trash.net, netdev@vger.kernel.org
Subject: Re: [PATCH v2 2/3] net_sched: Add accessor function for packet length for qdiscs
Date: Fri, 25 Jul 2008 05:16:06 -0700 (PDT) [thread overview]
Message-ID: <20080725.051606.107605277.davem@davemloft.net> (raw)
In-Reply-To: <20080725120849.GA25369@ff.dom.local>
From: Jarek Poplawski <jarkao2@gmail.com>
Date: Fri, 25 Jul 2008 12:08:49 +0000
> On Fri, Jul 25, 2008 at 04:52:15AM -0700, David Miller wrote:
> > What TCP depends upon is that DROP means DROP, and that the
> > packet never reached the device and has been freed.
>
> IMHO, TCP should depend on it's skb "refcount". A qdisc, after
> passing skb to other qdisc shouldn't depend on TCP's "refcount"
> because not everything has to work like TCP.
I think it is reasonable for TCP to expect lower layers to
not return garbage.
We have cases like this all over the stack, where some code gives some
specific return value, which means "the packet was freed and not
further processed."
There is no difference for this case.
next prev parent reply other threads:[~2008-07-25 12:16 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-19 23:34 [PATCH v2 0/3] Add size table feature for qdiscs Jussi Kivilinna
2008-07-19 23:35 ` [PATCH v2 1/3] net_sched: Add qdisc_enqueue wrapper Jussi Kivilinna
2008-07-19 23:35 ` [PATCH v2 2/3] net_sched: Add accessor function for packet length for qdiscs Jussi Kivilinna
2008-07-25 10:57 ` Jarek Poplawski
2008-07-25 10:57 ` David Miller
2008-07-25 11:37 ` Jarek Poplawski
2008-07-25 11:49 ` David Miller
2008-07-26 13:21 ` Patrick McHardy
2008-07-26 14:18 ` Jarek Poplawski
2008-07-30 10:47 ` Patrick McHardy
2008-07-30 11:19 ` Jarek Poplawski
2008-07-30 11:21 ` Patrick McHardy
2008-07-30 11:37 ` Jarek Poplawski
2008-07-30 11:40 ` Patrick McHardy
2008-07-30 11:48 ` David Miller
2008-07-30 11:52 ` Patrick McHardy
2008-07-30 12:19 ` Jarek Poplawski
2008-07-30 20:50 ` Jarek Poplawski
2008-07-25 11:53 ` Jarek Poplawski
2008-07-25 11:52 ` David Miller
2008-07-25 12:08 ` Jarek Poplawski
2008-07-25 12:16 ` David Miller [this message]
2008-07-25 12:29 ` Jussi Kivilinna
2008-07-25 12:54 ` Jarek Poplawski
2008-07-25 13:15 ` Jussi Kivilinna
2008-07-25 17:46 ` Jarek Poplawski
2008-07-25 18:02 ` Jarek Poplawski
2008-07-19 23:35 ` [PATCH v2 3/3] net_sched: Add size table " Jussi Kivilinna
2008-07-20 7:09 ` [PATCH v2 0/3] Add size table feature " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080725.051606.107605277.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jarkao2@gmail.com \
--cc=jussi.kivilinna@mbnet.fi \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).