From: Octavian Purdila <opurdila@ixiacom.com>
To: David Miller <davem@davemloft.net>
Cc: herbert@gondor.apana.org.au, netdev@vger.kernel.org
Subject: Re: [RFC][PATCH 1/3] net: per skb control messages
Date: Fri, 25 Jul 2008 02:14:11 +0300 [thread overview]
Message-ID: <200807250214.11298.opurdila@ixiacom.com> (raw)
In-Reply-To: <20080724.151733.215864673.davem@davemloft.net>
On Friday 25 July 2008, David Miller wrote:
> From: Octavian Purdila <opurdila@ixiacom.com>
> Date: Fri, 25 Jul 2008 01:12:03 +0300
>
> > On Friday 25 July 2008, David Miller wrote:
> > > We have a timestamp in the SKB already, why don't you simply override
> > > it when your feature is enable and set a single flag bit that
> > > indicates you used a HW timestamp to set that timestamp?
> >
> > I thought of something similar, but I am not sure if I can to so, as it
> > seems that the skb->tstamp requires current gettimeofday semantics at
> > least in netfilter's ipt_time module.
>
> Can your timestamp format at least be converted to
> gettimeofday() format?
>
> I thought we had a ton of accessor functions that code uses to access
> the timestamp? You should be able to do your translation in those
> routines.
Sure but the problem is that the NIC hw timestamp is not synced with the CPU
time. In that case I think that the netfilter rules which are looking at the
timestamp will be messed up.
[
A bit of general context about this annoying hw timestamp thing I keep
bringing up here:)
I know that this is a very specific thing and there is probably not a clean
solution to this and we will probably have to go with an in internal patch
approach.
But the thing is that we accumulated a lot such internal patches to the point
that makes it very hard to upgrade and track a recent Linux version. And I
feel that we need to stop adding new stuff in this pile, otherwise we will
not be able to keep up.
Thus my fixation with this very specific and not so significant thing in the
great Linux ecosystem. Probably I just chosen the wrong patch to battle.
]
Thanks,
tavi
next prev parent reply other threads:[~2008-07-24 23:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-23 22:01 [RFC][PATCH 0/3] net: per skb control messages Octavian Purdila
2008-07-23 22:01 ` [RFC][PATCH 1/3] " Octavian Purdila
2008-07-24 12:46 ` Herbert Xu
2008-07-24 13:34 ` Octavian Purdila
2008-07-24 15:01 ` Herbert Xu
2008-07-24 16:22 ` Octavian Purdila
2008-07-24 20:28 ` David Miller
2008-07-24 21:49 ` Octavian Purdila
2008-07-24 21:56 ` David Miller
2008-07-24 21:58 ` Stephen Hemminger
2008-07-24 22:35 ` Octavian Purdila
2008-07-24 23:05 ` Stephen Hemminger
2008-07-24 22:12 ` Octavian Purdila
2008-07-24 22:17 ` David Miller
2008-07-24 23:14 ` Octavian Purdila [this message]
2008-07-24 23:18 ` David Miller
2008-07-24 23:26 ` Octavian Purdila
2008-07-23 22:01 ` [RFC][PATCH 2/3] ip: support for SOL_SKB control messages for UDP/RAW sockets Octavian Purdila
2008-07-23 22:01 ` [RFC][PATCH 3/3] net: add SKB_SOL control messages Octavian Purdila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807250214.11298.opurdila@ixiacom.com \
--to=opurdila@ixiacom.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).