From: Stephen Hemminger <shemminger@vyatta.com>
To: cooloney@kernel.org, Jeff Garzik <jgarzik@pobox.com>
Cc: netdev@vger.kernel.org
Subject: [PATCH] blackfin_mac: unneeded assignment
Date: Fri, 25 Jul 2008 11:46:46 -0700 [thread overview]
Message-ID: <20080725114646.35f99145@extreme> (raw)
skb->dev is set by eth_type_trans already.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/drivers/net/bfin_mac.c 2008-07-25 10:19:53.000000000 -0700
+++ b/drivers/net/bfin_mac.c 2008-07-25 10:20:53.000000000 -0700
@@ -691,7 +691,6 @@ static void bfin_mac_rx(struct net_devic
(unsigned long)skb->tail);
dev->last_rx = jiffies;
- skb->dev = dev;
skb->protocol = eth_type_trans(skb, dev);
#if defined(BFIN_MAC_CSUM_OFFLOAD)
skb->csum = current_rx_ptr->status.ip_payload_csum;
next reply other threads:[~2008-07-25 18:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-25 18:46 Stephen Hemminger [this message]
2008-07-29 6:48 ` [PATCH] blackfin_mac: unneeded assignment Bryan Wu
2008-07-29 22:24 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080725114646.35f99145@extreme \
--to=shemminger@vyatta.com \
--cc=cooloney@kernel.org \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).