From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jussi Kivilinna" Subject: Re: [PATCH v2 2/3] net_sched: Add accessor function for packet length for qdiscs Date: Fri, 25 Jul 2008 16:15:03 +0300 Message-ID: <20080725161503.67994cpfp4jouz7k@hayate.ip6> References: <20080719233506.12596.59935.stgit@fate.lan> <20080725105748.GB10399@ff.dom.local> <20080725.035712.33516738.davem@davemloft.net> <20080725113757.GC10399@ff.dom.local> <20080725152932.93641c4o5qk1sx0g@hayate.ip6> <20080725125414.GB25369@ff.dom.local> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; DelSp="Yes"; format="flowed" Content-Transfer-Encoding: 7bit Cc: "David Miller" , kaber@trash.net, netdev@vger.kernel.org To: "Jarek Poplawski" Return-path: Received: from smtp2.dnainternet.fi ([87.94.96.112]:53849 "EHLO smtp2.dnainternet.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752658AbYGYNPH (ORCPT ); Fri, 25 Jul 2008 09:15:07 -0400 In-Reply-To: <20080725125414.GB25369@ff.dom.local> Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-ID: Quoting "Jarek Poplawski" : > On Fri, Jul 25, 2008 at 03:29:32PM +0300, Jussi Kivilinna wrote: >> Quoting "Jarek Poplawski" : >> >>> OK, I see htb did this earlier with ".packets", so it looks like I'm >>> wrong with this - sorry! (Anyway, it seems to unnecessarily restrict >>> the way qdisc are working.) >>> >> >> Would it be better for qdisc_enqueue() to pass packet length to caller? >> > > Is it's really needed? Actually, if it's only for stats, I really > can't see the reason why not to get this info old way - before > enqueing? (And this could be not enough if we want packets count > like in htb.) > qdisc_enqueue recalculates packet size if inner qdisc has size table set, so qdisc_pkt_len might return different length after qdisc_enqueue than what it was before. - Jussi