From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
To: David Miller <davem@davemloft.net>
Cc: vladislav.yasevich@hp.com, netdev@vger.kernel.org
Subject: Re: [RFC] sctp/tcp: Question -- ICMPv4 length check (not) redundant?
Date: Sat, 26 Jul 2008 09:10:07 +0100 [thread overview]
Message-ID: <20080726081007.GA7299@gerrit.erg.abdn.ac.uk> (raw)
In-Reply-To: <20080726.003617.265743493.davem@davemloft.net>
| What if the lower protocol doesn't have a header that it
| at least 8 bytes? :-)
|
| I think that's yet another reason why the check and counter bump were
| originally down in the per-protocol hander.
|
The only reason I can think of is RFC 1122, 3.2.2:
"Every ICMP error message includes the Internet header and at
least the first 8 data octets of the datagram that triggered
the error; more than 8 octets MAY be sent [...]"
But for ICMPv6 the requirement is less strict (RFC 4443, 2.4):
"Every ICMPv6 error message (type < 128) MUST include as much of
the IPv6 offending (invoking) packet (the packet that caused the
error) as possible without making the error message packet exceed
the minimum IPv6 MTU [IPv6]."
next prev parent reply other threads:[~2008-07-26 8:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-25 15:20 [RFC] sctp/tcp: Question -- ICMPv4 length check (not) redundant? Gerrit Renker
2008-07-26 2:15 ` Vlad Yasevich
2008-07-26 4:38 ` David Miller
2008-07-26 7:03 ` Gerrit Renker
2008-07-26 7:36 ` David Miller
2008-07-26 8:10 ` Gerrit Renker [this message]
2008-07-27 4:48 ` Herbert Xu
2008-07-27 4:51 ` Herbert Xu
2008-07-28 11:25 ` Gerrit Renker
2008-07-28 13:08 ` Herbert Xu
2008-07-28 13:14 ` Vlad Yasevich
2008-07-28 17:08 ` Gerrit Renker
2008-07-28 17:27 ` Vlad Yasevich
2008-07-28 17:44 ` Gerrit Renker
2008-07-28 18:09 ` Vlad Yasevich
2008-07-30 10:19 ` David Miller
2008-07-30 12:49 ` Vlad Yasevich
2008-07-29 1:56 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080726081007.GA7299@gerrit.erg.abdn.ac.uk \
--to=gerrit@erg.abdn.ac.uk \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=vladislav.yasevich@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).