From: David Miller <davem@davemloft.net>
To: miaox@cn.fujitsu.com
Cc: netdev@vger.kernel.org, pekkas@netcore.fi, yoshfuji@linux-ipv6.org
Subject: Re: [PATCH] IPv6: datagram_send_ctl() should exit immediately when an error occured
Date: Tue, 29 Jul 2008 23:58:06 -0700 (PDT) [thread overview]
Message-ID: <20080729.235806.263807229.davem@davemloft.net> (raw)
In-Reply-To: <488FC443.1080905@cn.fujitsu.com>
From: Miao Xie <miaox@cn.fujitsu.com>
Date: Wed, 30 Jul 2008 09:30:43 +0800
> When an error occured, datagram_send_ctl() should exit immediately rather than
> continue to run the for loop. Otherwise, the variable err might be changed and
> the error might be hidden.
>
> Fix this bug by using "goto" instead of "break".
>
> Signed-off-by: Miao Xie <miaox@cn.fujitsu.com>
Applied, thanks.
prev parent reply other threads:[~2008-07-30 6:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-30 1:30 [PATCH] IPv6: datagram_send_ctl() should exit immediately when an error occured Miao Xie
2008-07-30 6:58 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080729.235806.263807229.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=miaox@cn.fujitsu.com \
--cc=netdev@vger.kernel.org \
--cc=pekkas@netcore.fi \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).