From: Octavian Purdila <opurdila@ixiacom.com>
To: Ingo Oeser <netdev@axxeo.de>
Cc: Stephen Hemminger <shemminger@vyatta.com>,
Patrick Ohly <patrick.ohly@intel.com>,
netdev@vger.kernel.org
Subject: Re: [RFC][PATCH 1/1] net: support for hardware timestamping
Date: Tue, 29 Jul 2008 21:10:44 +0300 [thread overview]
Message-ID: <200807292110.45320.opurdila@ixiacom.com> (raw)
In-Reply-To: <200807291930.20033.netdev@axxeo.de>
On Tuesday 29 July 2008, Ingo Oeser wrote:
> Hi Octavian,
>
Hi Ingo,
> Just convert your hardware specific cookie you have into the nanoseconds
> resolution timstamp in skb->tstamp just before calling netif_rx()
> or net_receive_skb().
>
> These functions will not touch it, as long as they never see a ZERO
> value there. A ZERO value in tstamp.tv64 means, we have no timestamp.
>
> The difference to CPU clock doesn't matter.
> That compensation can be done by your driver or application at will.
> For mainline, compensation in driver might be preferred.
>
> As long as it is montonic increasing and related to time in any way,
> you could put anything there, I think :-)
>
In here:
net/netfilter/xt_time.c
it seems that the skb->tstamp needs to be CPU time.
Frankly I don't care about that, but the tstamp is also used in other places
like the IP and TCP code paths and I can't say that I barely understand that
part :)
But if it is ok to use any kind of monotonic increasing timestamp, that will
solve my problem, indeed.
Thanks,
tavi
next prev parent reply other threads:[~2008-07-29 18:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 0:07 [RFC][PATCH 0/1] net: support for hardware timestamps Octavian Purdila
2008-07-29 0:08 ` [RFC][PATCH 1/1] net: support for hardware timestamping Octavian Purdila
2008-07-29 14:52 ` Patrick Ohly
2008-07-29 15:49 ` Octavian Purdila
2008-07-30 9:35 ` Patrick Ohly
2008-07-30 13:38 ` Octavian Purdila
2008-07-30 14:00 ` Patrick Ohly
2008-07-29 15:54 ` Stephen Hemminger
2008-07-29 16:11 ` Octavian Purdila
2008-07-29 17:30 ` Ingo Oeser
2008-07-29 18:10 ` Octavian Purdila [this message]
2008-07-29 18:27 ` Ingo Oeser
2008-07-30 8:51 ` Patrick Ohly
2008-07-30 9:34 ` Ingo Oeser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807292110.45320.opurdila@ixiacom.com \
--to=opurdila@ixiacom.com \
--cc=netdev@axxeo.de \
--cc=netdev@vger.kernel.org \
--cc=patrick.ohly@intel.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).