From: David Miller <davem@davemloft.net>
To: akpm@linux-foundation.org
Cc: thomas.petazzoni@free-electrons.com, shemminger@vyatta.com,
jeff@garzik.org, netdev@vger.kernel.org, mpm@selenic.com
Subject: Re: [patch 12/12] Configure out ethtool support
Date: Wed, 30 Jul 2008 14:57:27 -0700 (PDT) [thread overview]
Message-ID: <20080730.145727.07367670.davem@davemloft.net> (raw)
In-Reply-To: <20080730144812.a71156f7.akpm@linux-foundation.org>
From: Andrew Morton <akpm@linux-foundation.org>
Date: Wed, 30 Jul 2008 14:48:12 -0700
> But I do think we should see some evidence that people are actually
> using CONFIG_ETHTOOL=n in real setups.
Heaven help them if they want to debug any real problems that
might involve checksumming, TSO, and other offload features.
Heaven help them if they want to probe the driver or firmware
version of the card they are using.
I'm sure you can find someone who runs with CONFIG_STAND_ON_MY_HEAD=y
but that doesn't mean that supporting such an option upstream makes
any sense.
We spent years getting rid of the per-driver module parameters to
configure these things. And now folks want to remove the common
infrastructure we created to do it.
6K is peanuts compared to the per-driver code that implements these
facilities.
next prev parent reply other threads:[~2008-07-30 21:57 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-30 19:39 [patch 12/12] Configure out ethtool support akpm
2008-07-30 20:37 ` Stephen Hemminger
2008-07-30 20:48 ` Thomas Petazzoni
2008-07-30 21:01 ` Stephen Hemminger
2008-07-30 21:35 ` Thomas Petazzoni
2008-07-30 21:48 ` Andrew Morton
2008-07-30 21:52 ` Thomas Petazzoni
2008-07-30 22:04 ` Andrew Morton
2008-07-30 23:35 ` Roland Dreier
2008-07-30 21:57 ` David Miller [this message]
2008-07-30 22:13 ` Andrew Morton
2008-07-30 22:33 ` David Miller
2008-07-31 10:39 ` David Woodhouse
2008-07-31 10:43 ` David Miller
2008-07-31 10:49 ` David Woodhouse
2008-07-31 10:47 ` David Miller
2008-07-31 15:36 ` Matt Mackall
2008-07-31 15:59 ` Stephen Hemminger
2008-07-31 16:11 ` Matt Mackall
2008-07-31 18:17 ` Evgeniy Polyakov
2008-07-30 21:35 ` David Miller
2008-07-30 21:44 ` Andrew Morton
2008-07-30 22:24 ` Matt Mackall
2008-07-30 22:37 ` David Miller
2008-07-30 23:05 ` Matt Mackall
2008-07-30 23:21 ` David Miller
2008-07-31 1:10 ` Matt Mackall
2008-07-31 1:23 ` David Miller
2008-07-31 10:22 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080730.145727.07367670.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=jeff@garzik.org \
--cc=mpm@selenic.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).