From: Roger Luethi <rl@hellgate.ch>
To: Willy Tarreau <w@1wt.eu>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH-2.4] via-rhine: fix duplex detection issue
Date: Wed, 30 Jul 2008 11:51:21 +0200 [thread overview]
Message-ID: <20080730095120.GA15833@core.hellgate.ch> (raw)
In-Reply-To: <20080729220802.GA25729@1wt.eu>
On Wed, 30 Jul 2008 00:08:02 +0200, Willy Tarreau wrote:
> The user that I am suggest using #1, but the maintainer that
> I am prefers #2. So I think I'll just go with the patch for
> the specific issue, and only consider the backport for my
> personal trees the day I have time to spend on this. That way
> we get one small patch for one small issue.
>
> I'd like to get your opinion on this, and to check with you
> if you are basically OK with that change in principle.
The major changes in 2.6 via-rhine have been in use for quite a while. It's
clearly an improvement over the one in 2.4 and every bit as stable. I'm not
sure a backport is worth it, though, especially considering that it's
incredibly easy to break via-rhine for some odd hardware or use case.
For 2.4, I'd stay with the devil that I know -- i.e. make minimal changes
only. But whatever you decide is fine with me. I trust that the 2.4
maintainer knows what is best for those users. Better than me, anyway.
Roger
next prev parent reply other threads:[~2008-07-30 9:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 22:08 [PATCH-2.4] via-rhine: fix duplex detection issue Willy Tarreau
2008-07-30 9:51 ` Roger Luethi [this message]
2008-07-30 12:41 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080730095120.GA15833@core.hellgate.ch \
--to=rl@hellgate.ch \
--cc=netdev@vger.kernel.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).