From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [patch 12/12] Configure out ethtool support Date: Wed, 30 Jul 2008 14:44:30 -0700 Message-ID: <20080730144430.0b2804c7.akpm@linux-foundation.org> References: <200807301939.m6UJd5lT012610@imap1.linux-foundation.org> <20080730.143532.124324888.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: jeff@garzik.org, netdev@vger.kernel.org, thomas.petazzoni@free-electrons.com, mpm@selenic.com To: David Miller Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:48337 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752436AbYG3VpT (ORCPT ); Wed, 30 Jul 2008 17:45:19 -0400 In-Reply-To: <20080730.143532.124324888.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 30 Jul 2008 14:35:32 -0700 (PDT) David Miller wrote: > From: akpm@linux-foundation.org > Date: Wed, 30 Jul 2008 12:39:04 -0700 > > > From: Thomas Petazzoni > > > > Add the CONFIG_ETHTOOL option which allows to remove support for ethtool, > > not necessarly used on embedded systems. As this is a size-reduction > > option, it depends on CONFIG_EMBEDDED. It allows to save ~6 kilobytes of > > kernel code: > > > > text data bss dec hex filename > > 1258447 123592 212992 1595031 185697 vmlinux > > 1252147 123592 212992 1588731 183dfb vmlinux.new > > -6300 0 0 -6300 -189C +/- > > > > Question: should we also remove ethtool-related functions from all network > > drivers ? > > > > This patch has been originally written by Matt Mackall > > , and is part of the Linux Tiny project. > > > > Signed-off-by: Thomas Petazzoni > > Cc: Matt Mackall > > Cc: "David S. Miller" > > Cc: Jeff Garzik > > Signed-off-by: Andrew Morton > > There is no way I'm applying this, ever. > > This change means you can't configure nearly all of the features on > your ethernet card. You can't even configure the link parameters > without ethtool support. This has been in linux-tiny for a long time - at least since 2.6.5. So either a) nobody sets CONFIG_ETHTOOL=n or b) you're wrong. I don't know which of these is the case and I don't know how to find out. I could be that the feature was useful back in the 2.6.5 days but is now completely useless, dunno. > If you want 6K back get rid of the random number generator, I hear > embedded people don't need that either :-) They'll take all they can get.