From: Octavian Purdila <opurdila@ixiacom.com>
To: Patrick Ohly <patrick.ohly@intel.com>
Cc: netdev@vger.kernel.org
Subject: Re: [RFC][PATCH 1/2] net: support for TX timestamps
Date: Wed, 30 Jul 2008 16:36:55 +0300 [thread overview]
Message-ID: <200807301636.55670.opurdila@ixiacom.com> (raw)
In-Reply-To: <1217424856.30512.180.camel@ecld0pohly>
On Wednesday 30 July 2008, Patrick Ohly wrote:
> > I don't think that skb->sk is guaranteed to be around in hard_start_xmit.
> > But we should not need it, if we overload the skb->tstamp, right?
>
> skb->sk is needed in skb_tx_timestamp() to send the copied skb with the
> time stamp back to the application, isn't it? skb_tx_timestamp() won't
> crash, but it won't be able to do the desired action either. Overloading
> skb->tstamp doesn't help with that.
>
Yes you are right :)
> I don't know where the connection to the originating socket is lost, but
> in linux-2.6 as of one week ago (not 2.6.26, as I said above) the
> skb->sk pointer is indeed NULL for the PTP broadcast packets - I just
> checked again.
Thanks for letting me know, I will look into it.
tavi
next prev parent reply other threads:[~2008-07-30 13:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 0:35 [RFC][PATCH 0/2] net: support for TX timestamps Octavian Purdila
2008-07-29 0:35 ` [RFC][PATCH 1/2] " Octavian Purdila
2008-07-30 12:43 ` Patrick Ohly
2008-07-30 13:15 ` Octavian Purdila
2008-07-30 13:34 ` Patrick Ohly
2008-07-30 13:36 ` Octavian Purdila [this message]
2008-07-29 0:35 ` [RFC][PATCH 2/2] ip: support for TX timestamps on UDP and RAW sockets Octavian Purdila
2008-07-30 9:47 ` [RFC][PATCH 0/2] net: support for TX timestamps Ingo Oeser
2008-07-30 13:02 ` Octavian Purdila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807301636.55670.opurdila@ixiacom.com \
--to=opurdila@ixiacom.com \
--cc=netdev@vger.kernel.org \
--cc=patrick.ohly@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).