netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, mjg59@srcf.ucam.org,
	ben.collins@canonical.com, samuel@sortiz.org
Subject: Re: [patch 08/11] nsc-ircc: default to dongle type 9 on IBM hardware
Date: Wed, 30 Jul 2008 17:07:20 -0700	[thread overview]
Message-ID: <20080730170720.041577ed.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080730.170057.47288436.davem@davemloft.net>

On Wed, 30 Jul 2008 17:00:57 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:

> From: akpm@linux-foundation.org
> Date: Wed, 30 Jul 2008 12:37:40 -0700
> 
> > This is necessary to set the dongle type on the nsc driver in order to get
> > it to work correctly.  Thinkpads all appear to use dongle type 9.  This
> > patch defaults nsc devices with an IBM PnP descriptor to use type 9.
> > 
> > Signed-off-by: Matthew Garrett <mjg59@srcf.ucam.org>
> > Signed-off-by: Ben Collins <ben.collins@canonical.com>
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> 
> Ugly, but what can we do? :-)

yes, it seems a reasonable compromise short of a full-blown
blacklisting thingy.

> Applied, thanks!

I have a feeling that 2.6.25.x and 2.6.26.x will want this one too.  I
found it hard to judge how important this fix actually is.  But
thinkpads are pretty common!



  reply	other threads:[~2008-07-31  0:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-30 19:37 [patch 08/11] nsc-ircc: default to dongle type 9 on IBM hardware akpm
2008-07-31  0:00 ` David Miller
2008-07-31  0:07   ` Andrew Morton [this message]
2008-07-31  0:13     ` Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080730170720.041577ed.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=ben.collins@canonical.com \
    --cc=davem@davemloft.net \
    --cc=mjg59@srcf.ucam.org \
    --cc=netdev@vger.kernel.org \
    --cc=samuel@sortiz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).