From: akpm@linux-foundation.org
To: jeff@garzik.org
Cc: netdev@vger.kernel.org, akpm@linux-foundation.org,
dsaxena@plexity.net, nico@cam.org, rmk@arm.linux.org.uk
Subject: [patch nacked? 3/4] Update smc91x driver with ARM Versatile board info
Date: Wed, 30 Jul 2008 12:40:48 -0700 [thread overview]
Message-ID: <200807301940.m6UJemPm012683@imap1.linux-foundation.org> (raw)
From: Deepak Saxena <dsaxena@plexity.net>
We need to specify a Versatile-specific SMC_IRQ_FLAGS value or the new
generic IRQ layer will complain thusly:
No IRQF_TRIGGER set_type function for IRQ 25 (<NULL>)
Signed-off-by: Deepak Saxena <dsaxena@plexity.net>
Cc: Jeff Garzik <jeff@garzik.org>
Cc: Russell King <rmk@arm.linux.org.uk>
Cc: Nicolas Pitre <nico@cam.org>
On Fri, 20 Oct 2006 22:50:40 +0100
Russell King <rmk@arm.linux.org.uk> wrote:
> On Fri, Oct 20, 2006 at 02:42:04PM -0700, akpm@linux-foundation.org wrote:
> > We need to specify a Versatile-specific SMC_IRQ_FLAGS value or the new
> > generic IRQ layer will complain thusly:
>
> I don't think I heard anything back from my previous suggestion that
> the IRQ flags are passed through the platform device IRQ resource.
>
> Doing so would avoid adding yet another platform specific block into
> the file.
>
> BTW, Integrator platforms will also suffer from this, which will add
> another ifdef to this header.
>
> Let's do it right and arrange to pass these flags from the platform
> code. It's not like they're in a critical path.
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/net/smc91x.h | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff -puN drivers/net/smc91x.h~update-smc91x-driver-with-arm-versatile-board-info drivers/net/smc91x.h
--- a/drivers/net/smc91x.h~update-smc91x-driver-with-arm-versatile-board-info
+++ a/drivers/net/smc91x.h
@@ -435,6 +435,24 @@ static inline void LPD7_SMC_outsw (unsig
#include <asm/unit/smc91111.h>
+#elif defined(CONFIG_ARCH_VERSATILE)
+
+#define SMC_CAN_USE_8BIT 1
+#define SMC_CAN_USE_16BIT 1
+#define SMC_CAN_USE_32BIT 1
+#define SMC_NOWAIT 1
+
+#define SMC_inb(a, r) readb((a) + (r))
+#define SMC_inw(a, r) readw((a) + (r))
+#define SMC_inl(a, r) readl((a) + (r))
+#define SMC_outb(v, a, r) writeb(v, (a) + (r))
+#define SMC_outw(v, a, r) writew(v, (a) + (r))
+#define SMC_outl(v, a, r) writel(v, (a) + (r))
+#define SMC_insl(a, r, p, l) readsl((a) + (r), p, l)
+#define SMC_outsl(a, r, p, l) writesl((a) + (r), p, l)
+
+#define SMC_IRQ_FLAGS (0)
+
#else
/*
_
next reply other threads:[~2008-07-30 19:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-30 19:40 akpm [this message]
2008-07-30 22:42 ` [patch nacked? 3/4] Update smc91x driver with ARM Versatile board info Russell King
2008-07-30 23:08 ` Andrew Morton
2008-07-30 23:41 ` Russell King
2008-07-30 23:51 ` Andrew Morton
2008-07-31 8:15 ` Russell King
2008-07-31 10:16 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807301940.m6UJemPm012683@imap1.linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dsaxena@plexity.net \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=nico@cam.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).