netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: akpm@linux-foundation.org, jeff@garzik.org,
	netdev@vger.kernel.org, davem@davemloft.net, mpm@selenic.com
Subject: Re: [patch 12/12] Configure out ethtool support
Date: Wed, 30 Jul 2008 22:48:49 +0200	[thread overview]
Message-ID: <20080730224849.59852c68@surf> (raw)
In-Reply-To: <20080730133727.7774de6a@extreme>

Le Wed, 30 Jul 2008 13:37:27 -0700,
Stephen Hemminger <shemminger@vyatta.com> a écrit :

> This option needs to be forced on when bridging or bonding is
> selected.

Do you mean something like the following fixup patch ?

Thanks,

Thomas

Make sure ETHTOOL support is selected when bonding and bridging are
requested.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

---
 drivers/net/Kconfig |    1 +
 net/bridge/Kconfig  |    1 +
 2 files changed, 2 insertions(+)

Index: linuxdev/drivers/net/Kconfig
===================================================================
--- linuxdev.orig/drivers/net/Kconfig
+++ linuxdev/drivers/net/Kconfig
@@ -61,6 +61,7 @@
 config BONDING
 	tristate "Bonding driver support"
 	depends on INET
+	select ETHTOOL
 	---help---
 	  Say 'Y' or 'M' if you wish to be able to 'bond' multiple Ethernet
 	  Channels together. This is called 'Etherchannel' by Cisco,
Index: linuxdev/net/bridge/Kconfig
===================================================================
--- linuxdev.orig/net/bridge/Kconfig
+++ linuxdev/net/bridge/Kconfig
@@ -6,6 +6,7 @@
 	tristate "802.1d Ethernet Bridging"
 	select LLC
 	select STP
+	select ETHTOOL
 	---help---
 	  If you say Y here, then your Linux box will be able to act as an
 	  Ethernet bridge, which means that the different Ethernet segments it


-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers and embedded Linux development,
consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2008-07-30 20:48 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-30 19:39 [patch 12/12] Configure out ethtool support akpm
2008-07-30 20:37 ` Stephen Hemminger
2008-07-30 20:48   ` Thomas Petazzoni [this message]
2008-07-30 21:01     ` Stephen Hemminger
2008-07-30 21:35       ` Thomas Petazzoni
2008-07-30 21:48         ` Andrew Morton
2008-07-30 21:52           ` Thomas Petazzoni
2008-07-30 22:04             ` Andrew Morton
2008-07-30 23:35               ` Roland Dreier
2008-07-30 21:57           ` David Miller
2008-07-30 22:13             ` Andrew Morton
2008-07-30 22:33               ` David Miller
2008-07-31 10:39               ` David Woodhouse
2008-07-31 10:43                 ` David Miller
2008-07-31 10:49                   ` David Woodhouse
2008-07-31 10:47                 ` David Miller
2008-07-31 15:36                   ` Matt Mackall
2008-07-31 15:59                     ` Stephen Hemminger
2008-07-31 16:11                       ` Matt Mackall
2008-07-31 18:17                     ` Evgeniy Polyakov
2008-07-30 21:35 ` David Miller
2008-07-30 21:44   ` Andrew Morton
2008-07-30 22:24   ` Matt Mackall
2008-07-30 22:37     ` David Miller
2008-07-30 23:05       ` Matt Mackall
2008-07-30 23:21         ` David Miller
2008-07-31  1:10           ` Matt Mackall
2008-07-31  1:23             ` David Miller
2008-07-31 10:22               ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080730224849.59852c68@surf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=jeff@garzik.org \
    --cc=mpm@selenic.com \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).