netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Hutchings <bhutchings@solarflare.com>
To: David Miller <davem@davemloft.net>
Cc: buytenh@wantstofly.org, herbert@gondor.apana.org.au,
	netdev@vger.kernel.org, akarkare@marvell.com, nico@cam.org,
	dale@farnsworth.org
Subject: Re: using software TSO on non-TSO capable netdevices
Date: Thu, 31 Jul 2008 14:19:30 +0100	[thread overview]
Message-ID: <20080731131929.GO10471@solarflare.com> (raw)
In-Reply-To: <20080731.053516.185810642.davem@davemloft.net>

David Miller wrote:
> From: Lennert Buytenhek <buytenh@wantstofly.org>
> Date: Thu, 31 Jul 2008 14:25:41 +0200
> 
> > At this point things seem to be CPU limited at the sender again.  E.g.
> > by simply dropping IRQF_SAMPLE_RANDOM from mv643xx_eth.c (the driver
> > used on the sender), throughput jumps to ~108 MiB/s, and I get:
>  ...
> > Putting the 5 * mss_now nagle hack back in doesn't seem to change
> > the gso_size distribution anymore at this point, and it doesn't
> > change the numbers much:
>  ...
> > The throughput with software GSO off again seems to be about ~93 MiB/s:
> 
> So I would conclude that at the moment we should just do the software
> GSO enabling thing (with the recent suggestions made by Herbert) and
> for the time being the nagle hack isn't something to consider closely.

You might want to think about providing a way for soft-GSO to generate
more lightweight structures than skbs.  The overhead for skb allocation
becomes quite significant beyond 1 Gbit/s, which is why we added the soft-
TSO implementation in sfc using per-interface pools of header buffers.  I
would guess niu would benefit from this sort of approach, though it looks
like all the other 10G NICs do TSO in hardware/firmware.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

  reply	other threads:[~2008-07-31 13:19 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-30 23:50 using software TSO on non-TSO capable netdevices Lennert Buytenhek
2008-07-30 23:56 ` David Miller
2008-07-31  0:41   ` Lennert Buytenhek
2008-07-31  1:10     ` David Miller
2008-07-31  1:45       ` Lennert Buytenhek
2008-07-31  3:54         ` Herbert Xu
2008-07-31  9:45           ` Lennert Buytenhek
2008-07-31 10:55             ` Herbert Xu
2008-07-31 12:37               ` Lennert Buytenhek
2008-07-31 12:59                 ` Herbert Xu
2008-08-03  8:23                   ` David Miller
2008-07-31  7:34       ` Ilpo Järvinen
2008-07-31  9:50         ` Lennert Buytenhek
2008-07-31 10:27           ` Ilpo Järvinen
2008-07-31  2:29     ` Herbert Xu
2008-07-31  2:36       ` Lennert Buytenhek
2008-07-31  3:03         ` Herbert Xu
2008-07-31  6:55           ` Ilpo Järvinen
2008-07-31  9:39             ` Lennert Buytenhek
2008-07-31 10:14           ` Lennert Buytenhek
2008-07-31 10:16             ` David Miller
2008-07-31 12:25               ` Lennert Buytenhek
2008-07-31 12:35                 ` David Miller
2008-07-31 13:19                   ` Ben Hutchings [this message]
2008-07-31 13:27                     ` Herbert Xu
2008-08-03  8:19                       ` David Miller
2008-08-03  8:55                         ` Herbert Xu
2008-08-07  6:07                           ` David Miller
2008-08-07  6:15                             ` Herbert Xu
2008-09-12  4:08                               ` David Miller
2008-08-07 11:50                             ` Lennert Buytenhek
2008-08-07 20:32                             ` Rick Jones
2008-08-07 22:44                               ` David Miller
2008-07-31 17:00 ` Rick Jones
2008-07-31 17:45   ` Lennert Buytenhek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080731131929.GO10471@solarflare.com \
    --to=bhutchings@solarflare.com \
    --cc=akarkare@marvell.com \
    --cc=buytenh@wantstofly.org \
    --cc=dale@farnsworth.org \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    --cc=nico@cam.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).