netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Divy Le Ray <divy@chelsio.com>
To: "Roland Dreier" <rdreier@cisco.com>
Cc: "Jeff Garzik" <jgarzik@pobox.com>, "Karen Xie" <kxie@chelsio.com>,
	netdev@vger.kernel.org, open-iscsi@googlegroups.com,
	davem@davemloft.net, michaelc@cs.wisc.edu,
	"Steve Wise" <swise@opengridcomputing.com>,
	daisyc@us.ibm.com, wenxiong@us.ibm.com, bhua@us.ibm.com,
	"Dimitrios Michailidis" <dm@chelsio.com>,
	"Casey Leedom" <leedom@chelsio.com>,
	"linux-scsi" <linux-scsi@vger.kernel.org>,
	"LKML" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator
Date: Thu, 31 Jul 2008 17:51:59 -0700	[thread overview]
Message-ID: <200807311752.00911.divy@chelsio.com> (raw)
In-Reply-To: <aday73jxdfs.fsf@cisco.com>

On Wednesday 30 July 2008 02:35:51 pm Roland Dreier wrote:
>  > * From a networking standpoint, our main concern becomes how this
>  > interacts with the networking stack.  In particular, I'm concerned
>  > based on reading the source that this driver uses "TCP port stealing"
>  > rather than using a totally separate MAC address (and IP).
>  >
>  > Stealing a TCP port on an IP/interface already assigned is a common
>  > solution in this space, but also a flawed one.  Precisely because the
>  > kernel and applications are unaware of this "special, magic TCP port"
>  > you open the potential for application problems that are very
>  > difficult for an admin to diagnose based on observed behavior.
>
> That's true, but using a separate MAC and IP opens up a bunch of other
> operational problems.  I don't think the right answer for iSCSI offload
> is clear yet.
>
>  - R.

Hi Jeff,

We've considered the approach of having a separate IP/MAC addresses to manage
iSCSI connections. In such a context, the stack would have to be unaware of
this iSCSI specific IP address. The iSCSI driver would then have to implement
at least its own ARP reply mechanism. DHCP too would have to be managed
separately. Most network setting/monitoring tools would also be unavailable.

The open-iscsi initiator is not a huge consumer of TCP connections, allocating
a TCP port from the stack would be reasonable in terms of resources in this
context. It is however unclear if it is an acceptable approach.

Our current implementation was designed to be the most tolerable one
within the constraints - real or expected - aforementioned.

Cheers,
Divy


  reply	other threads:[~2008-08-01  0:51 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-30  0:19 [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator Karen Xie
2008-07-30 18:15 ` Shyam_Iyer
2008-07-30 18:37   ` Karen Xie
2008-07-30 19:21 ` Roland Dreier
2008-07-30 19:35 ` Jeff Garzik
2008-07-30 21:35   ` Roland Dreier
2008-08-01  0:51     ` Divy Le Ray [this message]
2008-08-07 18:45       ` Divy Le Ray
2008-08-07 20:07         ` Mike Christie
2008-08-08 18:09         ` Steve Wise
2008-08-08 22:15           ` Jeff Garzik
2008-08-08 22:20             ` Jeff Garzik
2008-08-09  7:28             ` David Miller
2008-08-09 14:04               ` Steve Wise
2008-08-10  5:14               ` Roland Dreier
2008-08-10  5:47                 ` David Miller
2008-08-10  6:34                   ` Herbert Xu
2008-08-10 17:57                   ` Steve Wise
2008-08-11 16:09                   ` Roland Dreier
2008-08-11 21:09                     ` David Miller
2008-08-11 21:37                       ` Roland Dreier
2008-08-11 21:51                         ` David Miller
2008-08-11 23:20                       ` Steve Wise
2008-08-11 23:45                         ` Divy Le Ray
2008-08-12  0:22                         ` David Miller
2008-08-10  5:12             ` Roland Dreier
2008-08-10  5:46               ` David Miller
2008-08-11 16:07                 ` Roland Dreier
2008-08-11 21:08                   ` David Miller
2008-08-11 21:39                     ` Roland Dreier
2008-08-11 21:52                       ` David Miller
2008-08-11 18:13                 ` Rick Jones
2008-08-11 21:12                   ` David Miller
2008-08-11 21:41                     ` Roland Dreier
2008-08-11 21:53                       ` David Miller
2008-08-12 21:57                         ` Divy Le Ray
2008-08-12 22:01                           ` David Miller
2008-08-12 22:02                           ` David Miller
2008-08-12 22:21                             ` Divy Le Ray
2008-08-13  1:57                               ` Herbert Xu
2008-08-13 18:35                               ` Vladislav Bolkhovitin
2008-08-13 19:29                                 ` Jeff Garzik
2008-08-13 20:13                                   ` David Miller
2008-08-14 18:24                                   ` Vladislav Bolkhovitin
2008-08-14 21:59                                     ` Nicholas A. Bellinger
2008-08-13 20:23                                 ` David Miller
2008-08-14 18:27                                   ` Vladislav Bolkhovitin
2008-08-14 18:30                                     ` Vladislav Bolkhovitin
2008-08-13 21:27                         ` Roland Dreier
2008-08-13 22:08                           ` David Miller
2008-08-13 23:03                             ` Roland Dreier
2008-08-13 23:12                               ` David Miller
2008-08-14  1:26                                 ` Tom Tucker
2008-08-14  1:37                                   ` David Miller
2008-08-14  1:52                                     ` Steve Wise
2008-08-14  2:05                                       ` David Miller
2008-08-14  2:44                                         ` Steve Wise
2008-08-14  1:57                                     ` Tom Tucker
2008-08-14  2:07                                       ` David Miller
2008-08-14  2:09                                   ` David Miller
2008-08-14 20:45                     ` Andrew Gallatin
2008-08-14 22:23                       ` David Miller
2008-08-15 12:19                         ` Andrew Gallatin
2008-08-10  6:24               ` Herbert Xu
2008-08-10  9:19               ` Alan Cox
2008-08-10 12:49                 ` Jeff Garzik
2008-08-10 14:54                   ` James Bottomley
     [not found]                     ` <1218380086.3418.21.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-08-11 16:50                       ` Mike Christie
2008-07-31  1:24   ` Karen Xie
2008-07-31 12:45     ` Boaz Harrosh
2008-07-31 12:33 ` Boaz Harrosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200807311752.00911.divy@chelsio.com \
    --to=divy@chelsio.com \
    --cc=bhua@us.ibm.com \
    --cc=daisyc@us.ibm.com \
    --cc=davem@davemloft.net \
    --cc=dm@chelsio.com \
    --cc=jgarzik@pobox.com \
    --cc=kxie@chelsio.com \
    --cc=leedom@chelsio.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=michaelc@cs.wisc.edu \
    --cc=netdev@vger.kernel.org \
    --cc=open-iscsi@googlegroups.com \
    --cc=rdreier@cisco.com \
    --cc=swise@opengridcomputing.com \
    --cc=wenxiong@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).