From: David Miller <davem@davemloft.net>
To: sven.wegener@stealer.net
Cc: marcin.slusarz@gmail.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, den@openvz.org
Subject: Re: [PATCH] net: Add missing extra2 parameter for ip_default_ttl sysctl
Date: Sun, 03 Aug 2008 14:07:51 -0700 (PDT) [thread overview]
Message-ID: <20080803.140751.57839905.davem@davemloft.net> (raw)
In-Reply-To: <alpine.LNX.1.10.0808032214130.29048@titan.stealer.net>
From: Sven Wegener <sven.wegener@stealer.net>
Date: Sun, 3 Aug 2008 22:18:59 +0200 (CEST)
> Commit 76e6ebfb40a2455c18234dcb0f9df37533215461 acceses the extra2 parameter of
> the ip_default_ttl ctl_table, but it is never set to a meaningful value. When
> e84f84f276473dcc673f360e8ff3203148bdf0e2 is applied, we'll oops in
> rt_cache_invalidate(). Set extra2 to init_net, to avoid that.
>
> Reported-by: Marcin Slusarz <marcin.slusarz@gmail.com>
> Signed-off-by: Sven Wegener <sven.wegener@stealer.net>
> Tested-by: Marcin Slusarz <marcin.slusarz@gmail.com>
> Acked-by: Denis V. Lunev <den@openvz.org>
Applied, thanks a lot.
Please provide commit header line text when referencing SHA IDs,
as the SHA IDs can change when patches are applied to different
trees. Here is the actual changelog message I used so you can
see what I mean:
net: Add missing extra2 parameter for ip_default_ttl sysctl
Commit 76e6ebfb40a2455c18234dcb0f9df37533215461 ("netns: add namespace
parameter to rt_cache_flush") acceses the extra2 parameter of the
ip_default_ttl ctl_table, but it is never set to a meaningful
value. When e84f84f276473dcc673f360e8ff3203148bdf0e2 ("netns: place
rt_genid into struct net") is applied, we'll oops in
rt_cache_invalidate(). Set extra2 to init_net, to avoid that.
Reported-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Signed-off-by: Sven Wegener <sven.wegener@stealer.net>
Tested-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Acked-by: Denis V. Lunev <den@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
prev parent reply other threads:[~2008-08-03 21:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-03 17:02 oops in rt_cache_invalidate (2.6.27-rc1-2b12a4c) Marcin Slusarz
2008-08-03 18:56 ` Denis V. Lunev
2008-08-03 19:24 ` Sven Wegener
2008-08-03 19:43 ` Sven Wegener
2008-08-03 19:48 ` Sven Wegener
2008-08-03 19:52 ` Marcin Slusarz
2008-08-03 20:04 ` Denis V. Lunev
2008-08-03 20:18 ` [PATCH] net: Add missing extra2 parameter for ip_default_ttl sysctl Sven Wegener
2008-08-03 21:07 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080803.140751.57839905.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=den@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sven.wegener@stealer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).