From: Jarek Poplawski <jarkao2@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: emil.s.tantilov@intel.com, jeffrey.t.kirsher@intel.com,
netdev@vger.kernel.org
Subject: Re: [BUG] NULL pointer dereference in skb_dequeue
Date: Sun, 3 Aug 2008 11:29:26 +0200 [thread overview]
Message-ID: <20080803092926.GA2971@ami.dom.local> (raw)
In-Reply-To: <20080802201944.GA14983@ami.dom.local>
On Sat, Aug 02, 2008 at 10:19:44PM +0200, Jarek Poplawski wrote:
> On Sat, Aug 02, 2008 at 12:18:15PM -0700, David Miller wrote:
...
> > Jarek, we can't put the root lock back into the netdev_queue, it
> > breaks all of the RCU handling of qdisc_destroy() which is fundamental
> > for how all the multiqueue stuff works now.
> >
> > See my other emails, it isn't even necessary anyways.
...
> Thanks for the explanations: BTW, I think, the qdisc_root_lock is a
> bit misleading name, if qdisc_lock is also used for taking root lock.
> Of course, this all makes sense, it simply needs more checking.
After some re-checking one more question: why do you think this
qdisc_root_lock() is safe as sch_tree_lock() (or anywhere else)? It
seems, eg. during deactivation it can get root_lock of qdisc_default,
and proceed with another qdisc?
Jarek P.
next prev parent reply other threads:[~2008-08-03 9:29 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-01 23:40 [BUG] NULL pointer dereference in skb_dequeue Jeff Kirsher
2008-08-02 1:03 ` David Miller
2008-08-02 1:20 ` David Miller
2008-08-02 9:36 ` Tantilov, Emil S
2008-08-02 13:37 ` Jarek Poplawski
2008-08-02 16:27 ` Jarek Poplawski
2008-08-02 19:18 ` David Miller
2008-08-02 19:22 ` David Miller
2008-08-02 19:45 ` Tantilov, Emil S
2008-08-02 21:46 ` Tantilov, Emil S
2008-08-03 2:26 ` David Miller
2008-08-08 19:38 ` Tantilov, Emil S
2008-08-09 7:29 ` David Miller
2008-08-09 22:32 ` Jarek Poplawski
2008-08-10 19:04 ` Jarek Poplawski
2008-08-11 10:01 ` Jarek Poplawski
2008-08-11 23:26 ` Paul E. McKenney
2008-08-12 6:36 ` Jarek Poplawski
2008-08-12 13:42 ` Paul E. McKenney
2008-08-12 18:09 ` Jarek Poplawski
2008-08-12 20:18 ` Paul E. McKenney
2008-08-12 21:15 ` Jarek Poplawski
2008-08-12 22:33 ` Paul E. McKenney
2008-08-02 20:19 ` Jarek Poplawski
2008-08-03 9:29 ` Jarek Poplawski [this message]
2008-08-03 9:50 ` Jarek Poplawski
2008-08-03 9:56 ` David Miller
2008-08-03 10:08 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080803092926.GA2971@ami.dom.local \
--to=jarkao2@gmail.com \
--cc=davem@davemloft.net \
--cc=emil.s.tantilov@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).