Netdev List
 help / color / mirror / Atom feed
From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: "Eilon Greenstein" <eilong@broadcom.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"Justin Chen" <justin.chen@hp.com>,
	"Bill Hayes" <bill.hayes@hp.com>,
	"Myron Stowe" <myron.stowe@hp.com>
Subject: Re: bnx2x null pointer dereference
Date: Mon, 4 Aug 2008 09:18:19 -0600	[thread overview]
Message-ID: <200808040918.19550.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <1217756201.547.3.camel@lb-tlvb-eliezer>

On Sunday 03 August 2008 03:36:41 am Eilon Greenstein wrote:
> 
> On Thu, 2008-07-31 at 15:49 -0700, Bjorn Helgaas wrote:
> > The crash below occurred because "params->bp == NULL" in
> > bnx2x_update_mng().  This is with the 1.45.11 driver version
> > on a RHEL 5.2 kernel.
> > 
> > This is on a prototype ia64 box, and I'm told that there's
> > some bnx2x firmware that is missing from the system firmware,
> > so this might be a "we don't care about this problem because
> > users will never see this situation" sort of thing.
> > 
> You are right - the problem is that the data from the board is invalid
> since there is no valid boot-code FW burned on it so the board cannot
> be used
> 
> > But it is annoying that it crashes the box rather than just
> > causing the driver to ignore the device.
> > 
> And this is also true - so we will fix it soon and submit a patch

Great!  Thanks for looking into this.  I'd be glad to help test
the patch when it's ready.

Bjorn

      reply	other threads:[~2008-08-04 15:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-31 22:49 bnx2x null pointer dereference Bjorn Helgaas
2008-08-03  9:36 ` Eilon Greenstein
2008-08-04 15:18   ` Bjorn Helgaas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200808040918.19550.bjorn.helgaas@hp.com \
    --to=bjorn.helgaas@hp.com \
    --cc=bill.hayes@hp.com \
    --cc=eilong@broadcom.com \
    --cc=justin.chen@hp.com \
    --cc=myron.stowe@hp.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox