From: Stephen Hemminger <shemminger@vyatta.com>
To: David Miller <davem@davemloft.net>
Cc: greearb@candelatech.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [RFC] netdev: debugging option
Date: Mon, 4 Aug 2008 09:37:42 -0700 [thread overview]
Message-ID: <20080804093742.395d271e@extreme> (raw)
In-Reply-To: <20080720.000509.20260185.davem@davemloft.net>
On Sun, 20 Jul 2008 00:05:09 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:
> From: Stephen Hemminger <shemminger@vyatta.com>
> Date: Sat, 19 Jul 2008 23:04:24 -0700
>
> > This adds a debugging option for network devices. It could grow to add other
> > uses, but for now just add some messages about device reference counting.
> >
> > Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>
> I think this is useful but it could use some minor
> mods before we put it in.
>
> For example, this thing will spam the logs in at least two
> common cases:
>
> 1) Lots of routing cache replacements
>
> 2) For older drivers using netif_rx() (and therefore, every
> current tunnel), every RX packet will trigger a log message
Fixed by later patch.
> So we really need to add some kind of run time enable and also a
> filter of some sort, even if it's just on device.
The sysctl in the patch is default off, so unless it is turned on,
the log is quiet
next prev parent reply other threads:[~2008-08-04 16:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-18 7:37 [BUG, NET] deadlock tearing down a bridged interface Dave Chinner
2008-07-18 15:44 ` Ben Greear
2008-07-19 1:17 ` Dave Chinner
2008-07-19 17:01 ` Ben Greear
2008-07-20 6:04 ` [RFC] netdev: debugging option Stephen Hemminger
2008-07-20 7:05 ` David Miller
2008-08-04 16:37 ` Stephen Hemminger [this message]
2008-08-04 21:31 ` David Miller
2008-08-04 22:34 ` Stephen Hemminger
2008-07-20 6:07 ` [BUG, NET] deadlock tearing down a bridged interface Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080804093742.395d271e@extreme \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=greearb@candelatech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).