From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: jeff@garzik.org
Cc: netdev@vger.kernel.org, davem@davemloft.net,
akpm@linux-foundation.org,
Alexander Duyck <alexander.h.duyck@intel.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [UPDATED PATCH 2/7] igb: fix null pointer dereference seen with fiber NICs
Date: Mon, 04 Aug 2008 14:59:46 -0700 [thread overview]
Message-ID: <20080804215942.16188.76410.stgit@localhost.localdomain> (raw)
In-Reply-To: <20080804215531.16188.73257.stgit@localhost.localdomain>
From: Alexander Duyck <alexander.h.duyck@intel.com>
With a fiber or serdes NIC installed the driver was causing a null pointer
dereference on driver unload.
Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/igb/igb_main.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/igb/igb_main.c b/drivers/net/igb/igb_main.c
index f23a048..cfed2b0 100644
--- a/drivers/net/igb/igb_main.c
+++ b/drivers/net/igb/igb_main.c
@@ -1372,7 +1372,8 @@ static void __devexit igb_remove(struct pci_dev *pdev)
unregister_netdev(netdev);
- if (!igb_check_reset_block(&adapter->hw))
+ if (adapter->hw.phy.ops.reset_phy &&
+ !igb_check_reset_block(&adapter->hw))
adapter->hw.phy.ops.reset_phy(&adapter->hw);
igb_remove_device(&adapter->hw);
next prev parent reply other threads:[~2008-08-04 21:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-04 21:59 [UPDATED PATCH 0/7] igb fixes and cleanups Jeff Kirsher
2008-08-04 21:59 ` [UPDATED PATCH 1/7] igb: fix comments Jeff Kirsher
2008-08-04 21:59 ` Jeff Kirsher [this message]
2008-08-04 21:59 ` [UPDATED PATCH 3/7] igb: fixes 82576 serdes init to correctly support manual flow control changes Jeff Kirsher
2008-08-04 22:00 ` [UPDATED PATCH 4/7] igb: correct issue of set_mta member of mac.ops not being populated Jeff Kirsher
2008-08-04 22:00 ` [UPDATED PATCH 6/7] igb: remove igb_init_managability as it is deprecated Jeff Kirsher
2008-08-04 22:00 ` [UPDATED PATCH 7/7] igb: remove 82576 quad adapter Jeff Kirsher
2008-08-07 5:58 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080804215942.16188.76410.stgit@localhost.localdomain \
--to=jeffrey.t.kirsher@intel.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).