From: David Miller <davem@davemloft.net>
To: guijianfeng@cn.fujitsu.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] Add (struct sock*) sk parameter for send_ack()
Date: Wed, 06 Aug 2008 20:20:38 -0700 (PDT) [thread overview]
Message-ID: <20080806.202038.93643856.davem@davemloft.net> (raw)
In-Reply-To: <48981BDE.70201@cn.fujitsu.com>
From: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
Date: Tue, 05 Aug 2008 17:22:38 +0800
> Add (struct sock*) sk parameter for send_ack.
>
> Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
This patch by itself breaks the build.
Don't submit patches this way. Every patch applied should
still leave the tree building.
Also, since your OOPS and detailed description only exists
in the "0/3" email, it won't make it into the commit log
history where it belongs.
Considering all of this, I'd say you should fix this as
one big patch with a really nice commit log message.
Thanks.
next prev parent reply other threads:[~2008-08-07 3:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-05 9:22 [PATCH 1/3] Add (struct sock*) sk parameter for send_ack() Gui Jianfeng
2008-08-07 3:20 ` David Miller [this message]
2008-08-07 4:43 ` Gui Jianfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080806.202038.93643856.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=guijianfeng@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).