From: Simon Horman <horms@verge.net.au>
To: Alexander Beregalov <a.beregalov@gmail.com>
Cc: dhananjay@netxen.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] netxen_nic_hw.c: fix warnings
Date: Wed, 6 Aug 2008 12:16:53 +1000 [thread overview]
Message-ID: <20080806021653.GA19137@verge.net.au> (raw)
In-Reply-To: <20080805200516.GB17320@orion>
On Wed, Aug 06, 2008 at 12:05:16AM +0400, Alexander Beregalov wrote:
> From: Alexander Beregalov <a.beregalov@gmail.com>
>
> netxen_nic_hw.c: fix warnings
>
> drivers/net/netxen/netxen_nic_hw.c:1414: warning: format '%llx' expects type 'long long unsigned int', but argument 3 has type 'u64'
> drivers/net/netxen/netxen_nic_hw.c:1487: warning: format '%llx' expects type 'long long unsigned int', but argument 3 has type 'u64'
This seems to be the agreed work-around for this.
Acked-by: Simon Horman <horms@verge.net.au>
> Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
> ---
>
> drivers/net/netxen/netxen_nic_hw.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/netxen/netxen_nic_hw.c b/drivers/net/netxen/netxen_nic_hw.c
> index 96a3bc6..06a517b 100644
> --- a/drivers/net/netxen/netxen_nic_hw.c
> +++ b/drivers/net/netxen/netxen_nic_hw.c
> @@ -1411,7 +1411,8 @@ static int netxen_nic_pci_mem_read_direct(struct netxen_adapter *adapter,
> (netxen_nic_pci_is_same_window(adapter, off+size-1) == 0)) {
> write_unlock_irqrestore(&adapter->adapter_lock, flags);
> printk(KERN_ERR "%s out of bound pci memory access. "
> - "offset is 0x%llx\n", netxen_nic_driver_name, off);
> + "offset is 0x%llx\n", netxen_nic_driver_name,
> + (unsigned long long)off);
> return -1;
> }
>
> @@ -1484,7 +1485,8 @@ netxen_nic_pci_mem_write_direct(struct netxen_adapter *adapter, u64 off,
> (netxen_nic_pci_is_same_window(adapter, off+size-1) == 0)) {
> write_unlock_irqrestore(&adapter->adapter_lock, flags);
> printk(KERN_ERR "%s out of bound pci memory access. "
> - "offset is 0x%llx\n", netxen_nic_driver_name, off);
> + "offset is 0x%llx\n", netxen_nic_driver_name,
> + (unsigned long long)off);
> return -1;
> }
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2008-08-06 2:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-05 20:05 [PATCH] netxen_nic_hw.c: fix warnings Alexander Beregalov
2008-08-06 2:16 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080806021653.GA19137@verge.net.au \
--to=horms@verge.net.au \
--cc=a.beregalov@gmail.com \
--cc=dhananjay@netxen.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).