From: David Miller <davem@davemloft.net>
To: haoki@redhat.com
Cc: herbert@gondor.apana.org.au, m.s.tsirkin@gmail.com,
linux-kernel@vger.kernel.org, yoshfuji@linux-ipv6.org,
netdev@vger.kernel.org
Subject: Re: possible recursive locking in udp4_lib_rcv
Date: Sat, 09 Aug 2008 00:36:50 -0700 (PDT) [thread overview]
Message-ID: <20080809.003650.78513833.davem@davemloft.net> (raw)
In-Reply-To: <489D13F9.4000805@redhat.com>
From: Hideo AOKI <haoki@redhat.com>
Date: Fri, 08 Aug 2008 23:50:17 -0400
> Hello Herbert,
>
> Herbert Xu wrote:
> > On Fri, Aug 08, 2008 at 10:37:41PM +0800, Herbert Xu wrote:
> >> Never mind, I see the reason why it's there. What we should do
> >> is drop the lock when we hit an encapsulated socket since they
> >> don't need it at all.
> >
> > Here is the patch:
> >
> > udp: Drop socket lock for encapsulated packets
>
> Thank very much for fixing the bug.
Indeed, thanks Herbert.
Applied to net-2.6, and queued up for -stable.
prev parent reply other threads:[~2008-08-09 7:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-07 23:46 possible recursive locking in udp4_lib_rcv Michael S. Tsirkin
2008-08-08 14:28 ` Herbert Xu
2008-08-08 14:37 ` Herbert Xu
2008-08-08 15:01 ` Herbert Xu
2008-08-08 15:08 ` Michael S. Tsirkin
2008-08-09 3:50 ` Hideo AOKI
2008-08-09 7:36 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080809.003650.78513833.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=haoki@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=m.s.tsirkin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).