From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: [PATCH] sky2: Fix suspend/hibernation/shutdown regression with WOL enabled
Date: Sun, 10 Aug 2008 14:14:34 +0200
Message-ID: <200808101414.35626.rjw@sisk.pl>
References: <200808092332.29596.rjw@sisk.pl> <20080809235711.12c2f331@extreme>
Mime-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, Jeff Garzik <jeff@garzik.org>,
	Stephen Hemminger <shemminger@vyatta.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>
To: Stephen Hemminger <stephen.hemminger@vyatta.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from ogre.sisk.pl ([217.79.144.158]:49263 "EHLO ogre.sisk.pl"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752908AbYHJMMO (ORCPT <rfc822;netdev@vger.kernel.org>);
	Sun, 10 Aug 2008 08:12:14 -0400
In-Reply-To: <20080809235711.12c2f331@extreme>
Content-Disposition: inline
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Sunday, 10 of August 2008, Stephen Hemminger wrote:
> On Sat, 9 Aug 2008 23:32:28 +0200
> "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> 
> > sky2: Fix suspend/hibernation/shutdown regression with WOL enabled
> > 
> > On my test box with the Asus M3A32-MVP main board there is a
> > regression from 2.6.26 related to suspend, hibernation and
> > shutdown.  Namely, if Wake-on-LAN is enabled with
> > 'ethtool -s eth0 wol g', the box hangs solid during all of these
> > operations, while executing either sky2_suspend(), or
> > sky2_shutdown().  This patch fixes it for me.
> > 
> > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> > ---
> >  drivers/net/sky2.c |    3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > Index: linux-2.6/drivers/net/sky2.c
> > ===================================================================
> > --- linux-2.6.orig/drivers/net/sky2.c
> > +++ linux-2.6/drivers/net/sky2.c
> > @@ -665,7 +665,8 @@ static void sky2_phy_power_down(struct s
> >  		    GM_GPCR_FL_PASS | GM_GPCR_SPEED_100 | GM_GPCR_AU_ALL_DIS);
> >  
> >  	if (hw->chip_id != CHIP_ID_YUKON_EC) {
> > -		if (hw->chip_id == CHIP_ID_YUKON_EC_U) {
> > +		if (hw->chip_id == CHIP_ID_YUKON_EC_U
> > +		    && hw->chip_rev != CHIP_REV_YU_EC_U_B0) {
> >  			ctrl = gm_phy_read(hw, port, PHY_MARV_PHY_CTRL);
> >  
> >  			/* enable Power Down */
> 
> The problem is not unique to your chip version,

Well, that's the part I wasn't sure of.

> so patching out the power down is not the correct solution.

Sure.