netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* net-next-2.6 [PATCH 1/1] skbuff: Small NiT
@ 2008-08-11 17:48 Gerrit Renker
  2008-08-12  1:17 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Gerrit Renker @ 2008-08-11 17:48 UTC (permalink / raw)
  To: netdev; +Cc: David S. Miller

skbuff: Code readability NiT

Inserting a space between the `-' improved the C readability (some languages
allow hyphens within functions and variable names, which is confusing).

Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
--
 include/linux/skbuff.h |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -901,7 +901,7 @@ extern unsigned char *__pskb_pull_tail(struct sk_buff *skb, int delta);
 static inline unsigned char *__pskb_pull(struct sk_buff *skb, unsigned int len)
 {
 	if (len > skb_headlen(skb) &&
-	    !__pskb_pull_tail(skb, len-skb_headlen(skb)))
+	    !__pskb_pull_tail(skb, len - skb_headlen(skb)))
 		return NULL;
 	skb->len -= len;
 	return skb->data += len;
@@ -918,7 +918,7 @@ static inline int pskb_may_pull(struct sk_buff *skb, unsigned int len)
 		return 1;
 	if (unlikely(len > skb->len))
 		return 0;
-	return __pskb_pull_tail(skb, len-skb_headlen(skb)) != NULL;
+	return __pskb_pull_tail(skb, len - skb_headlen(skb)) != NULL;
 }
 
 /**
@@ -1321,7 +1321,7 @@ static inline int skb_padto(struct sk_buff *skb, unsigned int len)
 	unsigned int size = skb->len;
 	if (likely(size >= len))
 		return 0;
-	return skb_pad(skb, len-size);
+	return skb_pad(skb, len - size);
 }
 
 static inline int skb_add_data(struct sk_buff *skb,
-- 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: net-next-2.6 [PATCH 1/1] skbuff: Small NiT
  2008-08-11 17:48 net-next-2.6 [PATCH 1/1] skbuff: Small NiT Gerrit Renker
@ 2008-08-12  1:17 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-08-12  1:17 UTC (permalink / raw)
  To: gerrit; +Cc: netdev

From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Date: Mon, 11 Aug 2008 19:48:27 +0200

> skbuff: Code readability NiT
> 
> Inserting a space between the `-' improved the C readability (some languages
> allow hyphens within functions and variable names, which is confusing).
> 
> Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>

Applied, thanks Gerrit.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-08-12  1:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-11 17:48 net-next-2.6 [PATCH 1/1] skbuff: Small NiT Gerrit Renker
2008-08-12  1:17 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).