From: Ingo Molnar <mingo@elte.hu>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Randy Dunlap <randy.dunlap@oracle.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>, Jeff Garzik <jgarzik@pobox.com>
Subject: [PATCH] net, wd.c: fix undefined reference to `NS8390p_init'
Date: Mon, 11 Aug 2008 11:11:05 +0200 [thread overview]
Message-ID: <20080811091105.GA8141@elte.hu> (raw)
In-Reply-To: <20080807102931.1bb0607d@lxorguk.ukuu.org.uk>
* Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> On Thu, 7 Aug 2008 09:20:07 +0200 (CEST)
> Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> > On Wed, 6 Aug 2008, Randy Dunlap wrote:
> > > One randconfig ends with:
> > >
> > > drivers/built-in.o: In function `wd_probe1':
> > > wd.c:(.init.text+0x6179): undefined reference to `NS8390p_init'
> > > make[1]: *** [.tmp_vmlinux1] Error 1
> >
> > drivers/net/Makefile has:
> >
> > obj-$(CONFIG_WD80x3) += wd.o 8390.o
> >
> > So either wd_probe1() should call NS8390_init(), or obj-$(CONFIG_WD80x3)
> > should link with 8390p.o. Don't know which is the appropriate change
> > here (my gut feeling says the latter).
>
> Safest is the latter. The shared memory interface on the wd is full
> speed 8 or 16bit (depending on card/jumpers) but I'm not clear about
> the NIC. Most of the performance hit is on the packet transfer which
> is private methods on this device so using 8390p won't make a big
> difference on this board anyway.
Alan, Jeff, i triggered this too with latest -git, please pick up the
fix below if you dont have it already.
Ingo
------------------>
>From c03cb1727bb4c5433436bfb0fab59fdcc00749c3 Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@elte.hu>
Date: Mon, 11 Aug 2008 11:11:42 +0200
Subject: [PATCH] net, wd.c: fix undefined reference to `NS8390p_init'
fix:
drivers/built-in.o: In function `wd_probe1':
wd.c:(.init.text+0xb247): undefined reference to `NS8390p_init'
that triggers with:
http://redhat.com/~mingo/misc/config-Mon_Aug_11_10_40_46_CEST_2008.bad
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
drivers/net/Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/Makefile b/drivers/net/Makefile
index 7629c90..dc6dbf6 100644
--- a/drivers/net/Makefile
+++ b/drivers/net/Makefile
@@ -106,7 +106,7 @@ ifeq ($(CONFIG_FEC_MPC52xx_MDIO),y)
obj-$(CONFIG_FEC_MPC52xx) += fec_mpc52xx_phy.o
endif
obj-$(CONFIG_68360_ENET) += 68360enet.o
-obj-$(CONFIG_WD80x3) += wd.o 8390.o
+obj-$(CONFIG_WD80x3) += wd.o 8390p.o
obj-$(CONFIG_EL2) += 3c503.o 8390p.o
obj-$(CONFIG_NE2000) += ne.o 8390p.o
obj-$(CONFIG_NE2_MCA) += ne2.o 8390p.o
next prev parent reply other threads:[~2008-08-11 9:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080806182828.6bfe0a16.sfr@canb.auug.org.au>
2008-08-07 0:21 ` linux-next: Tree for August 6 (8390 et al) Randy Dunlap
2008-08-07 7:20 ` Geert Uytterhoeven
2008-08-07 9:29 ` Alan Cox
2008-08-11 9:11 ` Ingo Molnar [this message]
2008-08-11 9:47 ` [PATCH] net, wd.c: fix undefined reference to `NS8390p_init' Jeff Garzik
2008-08-11 11:11 ` Ingo Molnar
2008-08-11 20:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080811091105.GA8141@elte.hu \
--to=mingo@elte.hu \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=geert@linux-m68k.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).