Re: qdisc and down links (regression)

[Stephen Hemminger <stephen.hemminger@vyatta.com>]

On Fri, 08 Aug 2008 23:24:27 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:

> From: Stephen Hemminger <stephen.hemminger@vyatta.com>
> Date: Fri, 8 Aug 2008 14:32:01 -0700
> 
> > It fixes it for qdisc but not for ingress filters
> > 
> > # tc qdisc add dev eth0 handle ffff: ingress
> > # tc filter add dev eth0 parent ffff: protocol ip \
> >    prio 50 u32 match ip src 0.0.0.0/0 police rate 800kbit burst 10k drop flowid :1
> > RTNETLINK answers: Invalid argument
> > We have an error talking to the kernel
> > 
> > Another problem is that the ingress qdisc can no longer be deleted
> > successfully.
> 
> These problems should be fixed by the following patch which
> I've just pushed to net-2.6:
> 
> pkt_sched: Fix ingress deletion and filter attachment.
> 
> Based upon bug reports by Stephen Hemminger.
> 
> We still had some cases using ->qdisc instead of ->qdisc_sleeping.
> 
> Also, qdisc_lookup() should return ingress qdiscs.
> 
> Signed-off-by: David S. Miller <davem@davemloft.net>

Thanks, all fixed.