From: Rusty Russell <rusty@rustcorp.com.au>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: netdev@vger.kernel.org, Max Krasnyansky <maxk@qualcomm.com>
Subject: Re: [PATCH 2/2] tun: fallback if skb_alloc() fails on big packets
Date: Wed, 13 Aug 2008 13:24:55 +1000 [thread overview]
Message-ID: <200808131324.56071.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20080812101409.GA22114@gondor.apana.org.au>
On Tuesday 12 August 2008 20:14:09 Herbert Xu wrote:
> On Tue, Aug 12, 2008 at 04:25:53PM +1000, Rusty Russell wrote:
> > skb_alloc produces linear packets (using kmalloc()). That can fail,
> > so should we fall back to making paged skbs.
>
> I'm not sure that this is really a good idea. If anything then
> tries to expand the head of this skb, they may fail and be forced
> to drop the packet.
Yes, but it's no worse than now. virtio_net keeps a cache of allocated pages,
but that's more code; and if I'm going to generalize that I really should
create a shrinker callback, which produces locking issues.
So I decided this was probably enough for this merge window.
Rusty.
next prev parent reply other threads:[~2008-08-13 3:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-12 6:24 [PATCH 1/2] net: skb_copy_datagram_from_iovec() Rusty Russell
2008-08-12 6:25 ` [PATCH 2/2] tun: fallback if skb_alloc() fails on big packets Rusty Russell
2008-08-12 10:14 ` Herbert Xu
2008-08-13 3:24 ` Rusty Russell [this message]
2008-08-15 18:09 ` Max Krasnyansky
2008-08-15 22:15 ` David Miller
2008-08-15 22:14 ` [PATCH 1/2] net: skb_copy_datagram_from_iovec() David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808131324.56071.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=herbert@gondor.apana.org.au \
--cc=maxk@qualcomm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).