[PATCH] bridge: show offload settings

[PATCH] bridge: show offload settings

[Stephen Hemminger]

Add more ethtool generic operations to dump the bridge offload
settings.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

--- a/drivers/net/bonding/bond_main.c	2008-08-11 11:22:42.000000000 -0700
+++ b/drivers/net/bonding/bond_main.c	2008-08-11 11:26:07.000000000 -0700
@@ -4493,6 +4493,12 @@ static void bond_ethtool_get_drvinfo(str
 
 static const struct ethtool_ops bond_ethtool_ops = {
 	.get_drvinfo		= bond_ethtool_get_drvinfo,
+	.get_link		= ethtool_op_get_link,
+	.get_tx_csum		= ethtool_op_get_tx_csum,
+	.get_sg			= ethtool_op_get_sg,
+	.get_tso		= ethtool_op_get_tso,
+	.get_ufo		= ethtool_op_get_ufo,
+	.get_flags		= ethtool_op_get_flags,
 };
 
 /*

Re: [PATCH] bridge: show offload settings

[David Miller]

From: Stephen Hemminger <shemminger@vyatta.com>
Date: Fri, 15 Aug 2008 10:02:59 -0700

> Add more ethtool generic operations to dump the bridge offload
> settings.
> 
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

Applied, thanks.

Re: [PATCH] bridge: show offload settings

[Jay Vosburgh]

David Miller <davem@davemloft.net> wrote:

>From: Stephen Hemminger <shemminger@vyatta.com>
>Date: Fri, 15 Aug 2008 10:02:59 -0700
>
>> Add more ethtool generic operations to dump the bridge offload
>> settings.
>> 
>> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>
>Applied, thanks.

	I might be confused, but it looks like Stephen included the
wrong patch; it references "bridge" in the comments, but duplicates his
earlier patch for bonding:

Date: 	Fri, 15 Aug 2008 10:02:59 -0700
From: Stephen Hemminger <shemminger@vyatta.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: [PATCH] bridge: show offload settings
Organization: Vyatta

Add more ethtool generic operations to dump the bridge offload
settings.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

--- a/drivers/net/bonding/bond_main.c	2008-08-11 11:22:42.000000000 -0700
+++ b/drivers/net/bonding/bond_main.c	2008-08-11 11:26:07.000000000 -0700
@@ -4493,6 +4493,12 @@ static void bond_ethtool_get_drvinfo(str

 static const struct ethtool_ops bond_ethtool_ops = {
 	.get_drvinfo		= bond_ethtool_get_drvinfo,
+	.get_link		= ethtool_op_get_link,
+	.get_tx_csum		= ethtool_op_get_tx_csum,
+	.get_sg			= ethtool_op_get_sg,
+	.get_tso		= ethtool_op_get_tso,
+	.get_ufo		= ethtool_op_get_ufo,
+	.get_flags		= ethtool_op_get_flags,
 };

	-J

---
	-Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com

Re: [PATCH] bridge: show offload settings

[Stephen Hemminger]

Here is the correct patch to add more offload settings for bridge.
Earlier was the bonding one (sorry).

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>


--- a/net/bridge/br_device.c	2008-08-14 12:14:57.000000000 -0700
+++ b/net/bridge/br_device.c	2008-08-14 12:18:10.000000000 -0700
@@ -148,11 +148,16 @@ static int br_set_tx_csum(struct net_dev
 }
 
 static struct ethtool_ops br_ethtool_ops = {
-	.get_drvinfo = br_getinfo,
-	.get_link = ethtool_op_get_link,
-	.set_sg = br_set_sg,
-	.set_tx_csum = br_set_tx_csum,
-	.set_tso = br_set_tso,
+	.get_drvinfo    = br_getinfo,
+	.get_link	= ethtool_op_get_link,
+	.get_tx_csum	= ethtool_op_get_tx_csum,
+	.set_tx_csum 	= br_set_tx_csum,
+	.get_sg		= ethtool_op_get_sg,
+	.set_sg		= br_set_sg,
+	.get_tso	= ethtool_op_get_tso,
+	.set_tso	= br_set_tso,
+	.get_ufo	= ethtool_op_get_ufo,
+	.get_flags	= ethtool_op_get_flags,
 };
 
 void br_dev_setup(struct net_device *dev)

Re: [PATCH] bridge: show offload settings

[David Miller]

From: Stephen Hemminger <shemminger@vyatta.com>
Date: Fri, 15 Aug 2008 16:50:51 -0700

> Here is the correct patch to add more offload settings for bridge.
> Earlier was the bonding one (sorry).
> 
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

I'll fix this up, thanks.  Good thing I didn't push to
kernel.org yet :-)

Re: [PATCH] bridge: show offload settings

[David Miller]

From: Jay Vosburgh <fubar@us.ibm.com>
Date: Fri, 15 Aug 2008 15:59:43 -0700

> David Miller <davem@davemloft.net> wrote:
> 
> >From: Stephen Hemminger <shemminger@vyatta.com>
> >Date: Fri, 15 Aug 2008 10:02:59 -0700
> >
> >> Add more ethtool generic operations to dump the bridge offload
> >> settings.
> >> 
> >> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
> >
> >Applied, thanks.
> 
> 	I might be confused, but it looks like Stephen included the
> wrong patch; it references "bridge" in the comments, but duplicates his
> earlier patch for bonding:

This has been sorted out, thanks Jay.