netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jarek Poplawski <jarkao2@gmail.com>
To: Denys Fedoryshchenko <denys@visp.net.lb>
Cc: netdev@vger.kernel.org
Subject: Re: panic 2.6.27-rc3-git2, qdisc_dequeue_head
Date: Sat, 16 Aug 2008 16:27:07 +0200	[thread overview]
Message-ID: <20080816142706.GC7519@ami.dom.local> (raw)
In-Reply-To: <200808161613.59948.denys@visp.net.lb>

On Sat, Aug 16, 2008 at 04:13:59PM +0300, Denys Fedoryshchenko wrote:
...
> Here is what i got:
> Aug 16 16:07:33 192.168.20.66 kernel: [   61.930066] ------------[ cut here ]------------
> Aug 16 16:07:33 192.168.20.66 kernel: [   61.930066] WARNING: at include/linux/skbuff.h:692 qdisc_requeue+0x56/0x6e()

It's very helpful, thanks.

Here is another patch - please apply without removing the previous one yet.

Jarek P.

---

 include/net/sch_generic.h |    5 +++++
 net/sched/sch_api.c       |    2 +-
 2 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h
index a7abfda..4f28fa7 100644
--- a/include/net/sch_generic.h
+++ b/include/net/sch_generic.h
@@ -193,6 +193,11 @@ static inline struct Qdisc *qdisc_root(struct Qdisc *qdisc)
 	return qdisc->dev_queue->qdisc;
 }
 
+static inline struct Qdisc *qdisc_root_sleeping(struct Qdisc *qdisc)
+{
+	return qdisc->dev_queue->qdisc_sleeping;
+}
+
 /* The qdisc root lock is a mechanism by which to top level
  * of a qdisc tree can be locked from any qdisc node in the
  * forest.  This allows changing the configuration of some
diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c
index c25465e..5c7ae56 100644
--- a/net/sched/sch_api.c
+++ b/net/sched/sch_api.c
@@ -435,7 +435,7 @@ void qdisc_watchdog_init(struct qdisc_watchdog *wd, struct Qdisc *qdisc)
 {
 	hrtimer_init(&wd->timer, CLOCK_MONOTONIC, HRTIMER_MODE_ABS);
 	wd->timer.function = qdisc_watchdog;
-	wd->qdisc = qdisc;
+	wd->qdisc = qdisc_root_sleeping(qdisc);
 }
 EXPORT_SYMBOL(qdisc_watchdog_init);
 

  reply	other threads:[~2008-08-16 14:26 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-15 19:09 panic 2.6.27-rc3-git2, qdisc_dequeue_head Denys Fedoryshchenko
2008-08-15 20:16 ` Jarek Poplawski
2008-08-15 20:36   ` Denys Fedoryshchenko
2008-08-15 20:54     ` Denys Fedoryshchenko
2008-08-16  8:55       ` Jarek Poplawski
2008-08-16  9:13         ` Jarek Poplawski
2008-08-16 10:03           ` Denys Fedoryshchenko
2008-08-16 10:05             ` Denys Fedoryshchenko
2008-08-16 12:27               ` Jarek Poplawski
2008-08-16 12:24                 ` Denys Fedoryshchenko
2008-08-16 12:34                   ` Jarek Poplawski
2008-08-16 13:13                     ` Denys Fedoryshchenko
2008-08-16 14:27                       ` Jarek Poplawski [this message]
2008-08-16 15:28                         ` Denys Fedoryshchenko
2008-08-16 15:59                           ` Jarek Poplawski
2008-08-16 18:15                             ` Denys Fedoryshchenko
2008-08-16 18:52                               ` Jarek Poplawski
2008-08-16 19:22                                 ` Denys Fedoryshchenko
2008-08-16 19:47                                   ` Jarek Poplawski
2008-08-17  9:02                                     ` Denys Fedoryshchenko
2008-08-17  9:34                                       ` Jarek Poplawski
2008-08-17  9:35                                         ` Denys Fedoryshchenko
2008-08-17  9:52                                           ` Jarek Poplawski
2008-08-17 10:01                                             ` Denys Fedoryshchenko
2008-08-17 10:31                                               ` Jarek Poplawski
2008-08-17 10:55                                               ` Jarek Poplawski
2008-08-17 12:06                                                 ` Denys Fedoryshchenko
2008-08-17 12:18                                                   ` Denys Fedoryshchenko
2008-08-17 12:38                                                   ` Jarek Poplawski
2008-08-17 12:50                                                     ` Denys Fedoryshchenko
2008-08-17 13:03                                                       ` Denys Fedoryshchenko
2008-08-17 13:36                                                         ` Jarek Poplawski
2008-08-17 19:36                                                           ` Denys Fedoryshchenko
2008-08-17 21:47                                                             ` Jarek Poplawski
2008-08-17 22:02                                                               ` David Miller
2008-08-17 22:21                                                               ` Denys Fedoryshchenko
2008-08-17 22:32                                                                 ` Jarek Poplawski
2008-08-17 13:16                                                       ` Jarek Poplawski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080816142706.GC7519@ami.dom.local \
    --to=jarkao2@gmail.com \
    --cc=denys@visp.net.lb \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).