From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarek Poplawski Subject: Re: panic 2.6.27-rc3-git2, qdisc_dequeue_head Date: Mon, 18 Aug 2008 00:32:50 +0200 Message-ID: <20080817223250.GC2546@ami.dom.local> References: <20080815190905.M56388@visp.net.lb> <200808172236.17857.denys@visp.net.lb> <20080817214752.GA2546@ami.dom.local> <200808180121.40998.denys@visp.net.lb> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org To: Denys Fedoryshchenko Return-path: Received: from ug-out-1314.google.com ([66.249.92.171]:30977 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750806AbYHQWb7 (ORCPT ); Sun, 17 Aug 2008 18:31:59 -0400 Received: by ug-out-1314.google.com with SMTP id c2so131748ugf.37 for ; Sun, 17 Aug 2008 15:31:57 -0700 (PDT) Content-Disposition: inline In-Reply-To: <200808180121.40998.denys@visp.net.lb> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Aug 18, 2008 at 01:21:40AM +0300, Denys Fedoryshchenko wrote: > Short testing - TBF is working fine. No warnings, no oops, nothing yet. > Before - intensive changes was causing oops easily. I will test for 1 day > more with TBF. > > P.S. New shaper (based on flow classifier + HTB classes, instead of prio+tbf) > crashing very fast on loaded server. Probably it is another bug. > Here is message: > http://www.nuclearcat.com/files/crash-newshaper.txt I'll try to look at this "tomorrow". Thanks, Jarek P. > > On Monday 18 August 2008, Jarek Poplawski wrote: > > On Sun, Aug 17, 2008 at 10:36:17PM +0300, Denys Fedoryshchenko wrote: > > > I am lost in patches :-) > > > When you will be back, let me know if order and set of patches is > > > correct. Here is what i am using: > > > > > > http://www.nuclearcat.com/patches/00-prevfixes1.patch > > > http://www.nuclearcat.com/patches/00-prevfixes2.patch > > > http://www.nuclearcat.com/patches/01-take3.patch > > > http://www.nuclearcat.com/patches/02-fix1.patch > > > http://www.nuclearcat.com/patches/03-fix_patch_2.patch > > > > > > And thanks for your help! > > > I cannot take risk and put to wide production, since it is crashing > > > sometimes, but i guess in few days we can make it ready for production. > > > > OK, so please try to test with all these patches above plus one new > > patch below. > > > > Thanks, > > Jarek P. > > > > (04-fix_patch_3.patch) > > --- > > > > net/sched/sch_api.c | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c > > index c25465e..c8dc72e 100644 > > --- a/net/sched/sch_api.c > > +++ b/net/sched/sch_api.c > > @@ -638,9 +638,9 @@ static void notify_and_destroy(struct sk_buff *skb, > > struct nlmsghdr *n, u32 clid qdisc_notify(skb, n, clid, old, new); > > > > if (old) { > > - spin_lock_bh(&old->q.lock); > > + sch_tree_lock(old); > > qdisc_destroy(old); > > - spin_unlock_bh(&old->q.lock); > > + sch_tree_unlock(old); > > } > > } > > > > -- > > To unsubscribe from this list: send the line "unsubscribe netdev" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > >