From: David Miller <davem@davemloft.net>
To: netdev@vger.kernel.org
Cc: jarkao2@gmail.com
Subject: [PATCH 8/9]: sch_hfsc: Use ->requeue queue instead of ops.
Date: Mon, 18 Aug 2008 01:37:15 -0700 (PDT) [thread overview]
Message-ID: <20080818.013715.51438108.davem@davemloft.net> (raw)
sch_hfsc: Use ->requeue queue instead of ops.
In fact this "peek head SKB for len" sequence could be
optimized even further.
Signed-off-by: David S. Miller <davem@davemloft.net>
---
net/sched/sch_hfsc.c | 7 +------
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/net/sched/sch_hfsc.c b/net/sched/sch_hfsc.c
index ea46760..bed4fd2 100644
--- a/net/sched/sch_hfsc.c
+++ b/net/sched/sch_hfsc.c
@@ -896,12 +896,7 @@ qdisc_peek_len(struct Qdisc *sch)
return 0;
}
len = qdisc_pkt_len(skb);
- if (unlikely(sch->ops->requeue(skb, sch) != NET_XMIT_SUCCESS)) {
- if (net_ratelimit())
- printk("qdisc_peek_len: failed to requeue\n");
- qdisc_tree_decrease_qlen(sch, 1);
- return 0;
- }
+ __skb_queue_head(&sch->requeue, skb);
return len;
}
--
1.5.6.5.GIT
next reply other threads:[~2008-08-18 8:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-18 8:37 David Miller [this message]
2008-08-18 14:11 ` [PATCH 8/9]: sch_hfsc: Use ->requeue queue instead of ops Patrick McHardy
2008-08-19 5:29 ` David Miller
2008-08-19 13:03 ` Herbert Xu
2008-08-19 13:07 ` Patrick McHardy
2008-08-20 22:09 ` Jarek Poplawski
2008-08-20 22:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080818.013715.51438108.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jarkao2@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).