From: David Miller <davem@davemloft.net>
To: vladislav.yasevich@hp.com
Cc: yanghy@cn.fujitsu.com, netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
Subject: Re: [PATCH] IPv6:fix the return interface index when get it while no message is received
Date: Mon, 18 Aug 2008 22:38:57 -0700 (PDT) [thread overview]
Message-ID: <20080818.223857.125980599.davem@davemloft.net> (raw)
In-Reply-To: <48A9799B.4040409@hp.com>
From: Vlad Yasevich <vladislav.yasevich@hp.com>
Date: Mon, 18 Aug 2008 09:31:07 -0400
> I don't think that's correct at all. The code path shows here is
> when there are no received options and no sticky options set. In
> such case, we shouldn't be returning multicast or bound interfaces.
> We should be returning 0.
>
> Additionally the address returned is completely bogus as well. We
> are returning the address our peer instead of the one of our own
> addresses.
Yang, please fix this up, thank you.
next prev parent reply other threads:[~2008-08-19 5:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-18 6:07 [PATCH] IPv6:fix the return interface index when get it while no message is received Yang Hongyang
2008-08-18 6:22 ` David Miller
2008-08-18 13:31 ` Vlad Yasevich
2008-08-19 5:38 ` David Miller [this message]
2008-08-19 6:28 ` Yang Hongyang
2008-08-19 13:36 ` Vlad Yasevich
2008-08-20 2:56 ` Yang Hongyang
2008-08-20 13:10 ` Vlad Yasevich
2008-08-22 11:54 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2008-08-08 4:27 get receiving interface index " Yang Hongyang
2008-08-08 5:59 ` [PATCH] IPv6:fix the return interface index when get it " Yang Hongyang
2008-08-08 6:03 ` David Miller
2008-08-08 14:58 ` Vlad Yasevich
2008-08-18 5:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080818.223857.125980599.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=vladislav.yasevich@hp.com \
--cc=yanghy@cn.fujitsu.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).