Re: [PATCH]: Kill qdisc rcu freeing...

[Jarek Poplawski <jarkao2@gmail.com>]

On Sun, Aug 17, 2008 at 10:34:35PM -0700, David Miller wrote:
> 
> Ok, I flipped the switch.  I've checked in the following to
> net-2.6 and it seems to pass a bunch of smoke tests I just
> did (flood pings while adding and deleting various qdisc
> setups, etc.)
> 
> Jarek, I think we can possibly now revert that locking change
> you had to make because destroy was outside of RTNL?

Yes, I think there are these two patches only to revert:

----------
commit d4766692e72422f3b0f0e9ac6773d92baad07d51
Author: Jarek Poplawski <jarkao2@gmail.com>
Date:   Wed Aug 13 15:20:24 2008 -0700

    pkt_sched: Protect gen estimators under est_lock.

----------

commit 1cfa26661a85549063e369e2b40275eeaa7b923c
Author: Jarek Poplawski <jarkao2@gmail.com>
Date:   Mon Aug 11 18:11:06 2008 -0700

    pkt_sched: Add BH protection for qdisc_stab_lock.

----------

I guess, I don't need to send any patches, but let me know if I'm
wrong.

Thanks,
Jarek P.

> 
> pkt_sched: No longer destroy qdiscs from RCU.
> 
> We can now kill them synchronously with all of the
> previous dev_deactivate() cures.
> 
> This makes netdev destruction and shutdown saner as
> the qdiscs hold references to the device.
> 
> Signed-off-by: David S. Miller <davem@davemloft.net>
> ---
...