From: Simon Horman <horms@verge.net.au>
To: Sven Wegener <sven.wegener@stealer.net>
Cc: netdev@vger.kernel.org, lvs-devel@vger.kernel.org,
wensong@linux-vs.org, ja@ssi.bg
Subject: Re: [PATCH] ipvs: Fix race conditions in lblc scheduler
Date: Mon, 18 Aug 2008 22:20:21 +1000 [thread overview]
Message-ID: <20080818122018.GA11508@verge.net.au> (raw)
In-Reply-To: <alpine.LNX.1.10.0808180050440.12259@titan.stealer.net>
On Mon, Aug 18, 2008 at 12:52:08AM +0200, Sven Wegener wrote:
> We can't access the cache entry outside of our critical read-locked region,
> because someone may free that entry. And we also need to check in the critical
> region wether the destination is still available, i.e. it's not in the trash.
> If we drop our reference counter, the destination can be purged from the trash
> at any time. Our caller only guarantees that no destination is moved to the
> trash, while we are scheduling. Also there is no need for our own rwlock,
> there is already one in the service structure for use in the schedulers.
Hi Sven,
I need to look over these changes with a fresh set of eyes in the morning
- sorry that I didn't do that earlier today. I am very much in favour of
the changes that we made last week, and this patch at least looks a lot
like the changes we discussed. Do you think these should be pushed
into 2.6.27? Or perhaps even stable? They are real races, right?
next prev parent reply other threads:[~2008-08-18 12:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-17 22:52 [PATCH] ipvs: Fix race conditions in lblc scheduler Sven Wegener
2008-08-18 12:20 ` Simon Horman [this message]
2008-08-18 15:47 ` Sven Wegener
2008-08-18 23:19 ` Simon Horman
2008-08-18 23:38 ` Sven Wegener
2008-08-19 7:45 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080818122018.GA11508@verge.net.au \
--to=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sven.wegener@stealer.net \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).