From: Christof Schmitt <christof.schmitt@de.ibm.com>
To: Hirofumi Nakagawa <hnakagawa@miraclelinux.com>
Cc: dedekind@infradead.org, yoshfuji@linux-ipv6.org,
linux-mtd@lists.infradead.org, linux-s390@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] Remove duplicated unlikely() in IS_ERR()
Date: Mon, 18 Aug 2008 11:21:05 -0400 [thread overview]
Message-ID: <20080818152105.GA8883@schmichrtp.de.ibm.com> (raw)
In-Reply-To: <48A52D69.1040501@miraclelinux.com>
On Fri, Aug 15, 2008 at 04:16:57PM +0900, Hirofumi Nakagawa wrote:
> Hi
> Some drivers have duplicated unlikely() macros.
> IS_ERR() already has unlikely() in itself.
> This patch cleans up such pointless codes although there is no real
> effect on the kernel's behaviour.
>
> Thanks,
> Hirofumi Nakagawa
>
> Signed-off-by: Hirofumi Nakagawa <hnakagawa@miraclelinux.com>
> ---
> drivers/s390/scsi/zfcp_fsf.c | 32 ++++++++++++++++----------------
> fs/ubifs/find.c | 4 ++--
> fs/ubifs/gc.c | 8 ++++----
> fs/ubifs/tnc.c | 4 ++--
> fs/ubifs/xattr.c | 2 +-
> net/ipv6/af_inet6.c | 2 +-
> 6 files changed, 26 insertions(+), 26 deletions(-)
Thanks for spotting and fixing this. Could you split the zfcp changes
in a seperate patch? I will pick up the zfcp patch for a series of
fixes that i have pending here.
Christof
next prev parent reply other threads:[~2008-08-18 15:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-15 7:16 [PATCH] Remove duplicated unlikely() in IS_ERR() Hirofumi Nakagawa
2008-08-15 12:16 ` Artem Bityutskiy
2008-08-18 15:21 ` Christof Schmitt [this message]
2008-08-18 23:10 ` Mike Frysinger
2008-08-19 5:55 ` Artem Bityutskiy
2008-08-19 14:57 ` Artem Bityutskiy
2008-08-21 12:39 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080818152105.GA8883@schmichrtp.de.ibm.com \
--to=christof.schmitt@de.ibm.com \
--cc=dedekind@infradead.org \
--cc=hnakagawa@miraclelinux.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).