From mboxrd@z Thu Jan 1 00:00:00 1970 From: Denys Fedoryshchenko Subject: Re: [PATCH]: Schedule correct qdisc in watchdog. Date: Mon, 18 Aug 2008 15:45:29 +0300 Message-ID: <200808181545.30146.denys@visp.net.lb> References: <20080818091011.GC5434@ff.dom.local> <20080818112022.GA7158@ff.dom.local> <20080818113531.GB7158@ff.dom.local> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: David Miller , netdev@vger.kernel.org To: Jarek Poplawski Return-path: Received: from relay2.globalproof.net ([194.146.153.25]:38944 "EHLO relay2.globalproof.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751188AbYHRMql (ORCPT ); Mon, 18 Aug 2008 08:46:41 -0400 In-Reply-To: <20080818113531.GB7158@ff.dom.local> Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-ID: Patch applied, got another warning. [ 413.646102] [ 413.646102] ========================= [ 413.646102] [ BUG: held lock freed! ] [ 413.646102] ------------------------- [ 413.646102] pppd/4105 is freeing memory f6fe6e00-f6fe6eff, with a lock still held there! [ 413.646102] (&qdisc_rx_lock){-+..}, at: [] shutdown_scheduler_queue+0x1c/0x2e [ 413.646102] 3 locks held by pppd/4105: [ 413.646102] #0: (all_ppp_mutex){--..}, at: [] ppp_shutdown_interface+0x17/0xb0 [ppp_generic] [ 413.646102] #1: (rtnl_mutex){--..}, at: [] rtnl_lock+0xf/0x11 [ 413.647102] #2: (&qdisc_rx_lock){-+..}, at: [] shutdown_scheduler_queue+0x1c/0x2e [ 413.647102] [ 413.647102] stack backtrace: [ 413.647102] Pid: 4105, comm: pppd Not tainted 2.6.27-rc3-build-0031-12578-g96d2031-dirty #32 [ 413.647102] [] ? printk+0xf/0x18 [ 413.647102] [] debug_check_no_locks_freed+0xce/0xff [ 413.647102] [] kfree+0x78/0xc8 [ 413.647102] [] ? qdisc_destroy+0x8c/0x90 [ 413.647102] [] qdisc_destroy+0x8c/0x90 [ 413.647102] [] shutdown_scheduler_queue+0x23/0x2e [ 413.647102] [] dev_shutdown+0x3d/0x59 [ 413.647102] [] rollback_registered+0x128/0x1b1 [ 413.647102] [] unregister_netdevice+0x32/0x6e [ 413.647102] [] unregister_netdev+0x12/0x1a [ 413.647102] [] ppp_shutdown_interface+0x5c/0xb0 [ppp_generic] [ 413.647102] [] ppp_release+0x2c/0x5a [ppp_generic] [ 413.647102] [] __fput+0x99/0x136 [ 413.647102] [] fput+0x17/0x19 [ 413.647102] [] filp_close+0x47/0x51 [ 413.647102] [] sys_close+0x73/0xad [ 413.647102] [] sysenter_do_call+0x12/0x35 [ 413.647102] ======================= On Monday 18 August 2008, Jarek Poplawski wrote: