From: Jarek Poplawski <jarkao2@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: denys@visp.net.lb, netdev@vger.kernel.org
Subject: Re: [PATCH]: Schedule correct qdisc in watchdog.
Date: Tue, 19 Aug 2008 06:59:58 +0000 [thread overview]
Message-ID: <20080819065958.GB4376@ff.dom.local> (raw)
In-Reply-To: <20080818.205427.140031432.davem@davemloft.net>
On Mon, Aug 18, 2008 at 08:54:27PM -0700, David Miller wrote:
> From: Jarek Poplawski <jarkao2@gmail.com>
> Date: Mon, 18 Aug 2008 11:35:31 +0000
>
> > pkt_sched: Add lockdep annotation for qdisc locks
> >
> > Qdisc locks are initialized in the same function, qdisc_alloc(), so
> > lockdep can't distinguish tx qdisc lock from rx and reports "possible
> > recursive locking detected" when both these locks are taken eg. while
> > using act_mirred with ifb. This looks like a false positive. Anyway,
> > after this patch these locks will be reported more exactly.
> >
> > Reported-by: Denys Fedoryshchenko <denys@visp.net.lb>
> > Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
>
> Applied, thanks Jarek.
>
> I suspect we need to apply this lock annotation to the locks
> in the static qdiscs &noop_qdisc and &noqueue_qdisc.
>
I guess, we currently don't need this. At least ingress checks and
skipps acting for &noop_qdisc. I'd prefer to see some lockdep warning
first, or maybe you could show some scenario?
Jarek P.
next prev parent reply other threads:[~2008-08-19 7:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-18 8:39 [PATCH]: Schedule correct qdisc in watchdog David Miller
2008-08-18 9:10 ` Jarek Poplawski
2008-08-18 9:31 ` David Miller
2008-08-18 9:47 ` Jarek Poplawski
2008-08-18 10:10 ` David Miller
2008-08-18 10:35 ` Jarek Poplawski
2008-08-18 10:43 ` Jarek Poplawski
2008-08-18 11:04 ` Denys Fedoryshchenko
2008-08-18 11:20 ` Jarek Poplawski
2008-08-18 11:35 ` Jarek Poplawski
2008-08-18 12:45 ` Denys Fedoryshchenko
2008-08-18 12:58 ` Jarek Poplawski
2008-08-18 23:56 ` David Miller
2008-08-19 5:37 ` Jarek Poplawski
2008-08-19 5:39 ` David Miller
2008-08-19 5:42 ` Jarek Poplawski
2008-08-18 15:55 ` Jarek Poplawski
2008-08-18 18:05 ` Denys Fedoryshchenko
2008-08-19 3:54 ` David Miller
2008-08-19 6:59 ` Jarek Poplawski [this message]
2008-08-19 7:03 ` David Miller
2008-08-18 11:06 ` Jarek Poplawski
2008-08-19 3:51 ` David Miller
2008-08-19 4:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080819065958.GB4376@ff.dom.local \
--to=jarkao2@gmail.com \
--cc=davem@davemloft.net \
--cc=denys@visp.net.lb \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).