netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ursula Braun <ursula.braun@de.ibm.com>
To: jgarzik@pobox.com, netdev@vger.kernel.org, linux-s390@vger.kernel.org
Cc: "Klaus-D. Wacker" <kdwacker@de.ibm.com>,
	Ursula Braun <ursula.braun@de.ibm.com>
Subject: [patch 4/4] LCS recovery dumps when cable reconnect
Date: Thu, 21 Aug 2008 17:10:25 +0200	[thread overview]
Message-ID: <20080821151654.326848000@linux.vnet.ibm.com> (raw)
In-Reply-To: 20080821151021.069615000@linux.vnet.ibm.com

[-- Attachment #1: 603-lcs-recovery.diff --]
[-- Type: text/plain, Size: 1078 bytes --]

From: Klaus-D. Wacker <kdwacker@de.ibm.com>

LCS recovery dumps in irq routine when CCW address in
Subchannel Status Word (SCSW) is zero. This occurs
when recovery is driven after cable reconnect.

Signed-off-by: Klaus-D. Wacker <kdwacker@de.ibm.com>
Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
---

 drivers/s390/net/lcs.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff -urpN linux-2.6/drivers/s390/net/lcs.c linux-2.6-patched/drivers/s390/net/lcs.c
--- linux-2.6/drivers/s390/net/lcs.c	2008-08-20 15:54:46.000000000 +0200
+++ linux-2.6-patched/drivers/s390/net/lcs.c	2008-08-20 15:55:15.000000000 +0200
@@ -1412,7 +1412,8 @@ lcs_irq(struct ccw_device *cdev, unsigne
 	}
 	/* How far in the ccw chain have we processed? */
 	if ((channel->state != LCS_CH_STATE_INIT) &&
-	    (irb->scsw.cmd.fctl & SCSW_FCTL_START_FUNC)) {
+	    (irb->scsw.cmd.fctl & SCSW_FCTL_START_FUNC) &&
+	    (irb->scsw.cmd.cpa != 0)) {
 		index = (struct ccw1 *) __va((addr_t) irb->scsw.cmd.cpa)
 			- channel->ccws;
 		if ((irb->scsw.cmd.actl & SCSW_ACTL_SUSPENDED) ||

-- 

  parent reply	other threads:[~2008-08-21 15:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-21 15:10 [patch 0/4] s390: ctcm / lcs / claw fixes for 2.6.27 Ursula Braun
2008-08-21 15:10 ` [patch 1/4] claw: fix memory leak in claw_probe Ursula Braun
2008-08-21 15:10 ` [patch 2/4] claw: netdev->priv vs. netdev->ml_priv Ursula Braun
2008-08-21 15:10 ` [patch 3/4] ctcm: " Ursula Braun
2008-08-21 15:10 ` Ursula Braun [this message]
2008-08-27  9:19   ` [patch 4/4] LCS recovery dumps when cable reconnect Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080821151654.326848000@linux.vnet.ibm.com \
    --to=ursula.braun@de.ibm.com \
    --cc=jgarzik@pobox.com \
    --cc=kdwacker@de.ibm.com \
    --cc=linux-s390@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).