netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: David Witbrodt <dawitbro@sbcglobal.net>
Cc: Yinghai Lu <yhlu.kernel@gmail.com>,
	Vivek Goyal <vgoyal@redhat.com>,
	Bill Fink <billfink@mindspring.com>,
	linux-kernel@vger.kernel.org,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>, netdev <netdev@vger.kernel.org>
Subject: Re: HPET regression in 2.6.26 versus 2.6.25 -- found another user with the same regression
Date: Sat, 23 Aug 2008 17:03:58 +0200	[thread overview]
Message-ID: <20080823150358.GA8579@elte.hu> (raw)
In-Reply-To: <20080823133643.GA23766@elte.hu>


* Ingo Molnar <mingo@elte.hu> wrote:

> could you try the debug patch below ontop of latest tip/master:

please use the replacement debug patch below. (the previous one was 
buggy, it would likely lock up because it iterated incorrectly.)

[ and i'd also like to stress that this isnt a solution, this is a debug
  hack that can lead to a solution. ]

	Ingo

-------------->
>From dc1c9cafd20edacb14e902c5ee72547f14c12545 Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@elte.hu>
Date: Sat, 23 Aug 2008 15:33:51 +0200
Subject: [PATCH] debug: ignore resource conflicts

---
 kernel/resource.c |   10 +++++++---
 1 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/kernel/resource.c b/kernel/resource.c
index f5b518e..45877ec 100644
--- a/kernel/resource.c
+++ b/kernel/resource.c
@@ -156,15 +156,19 @@ static struct resource * __request_resource(struct resource *root, struct resour
 	for (;;) {
 		tmp = *p;
 		if (!tmp || tmp->start > end) {
+insert:
 			new->sibling = tmp;
 			*p = new;
 			new->parent = root;
 			return NULL;
 		}
-		p = &tmp->sibling;
-		if (tmp->end < start)
+		if (tmp->end < start) {
+			p = &tmp->sibling;
 			continue;
-		return tmp;
+		}
+		printk("ignoring resource conflict between %s/{%p..%p} and %s/{%p..%p}\n", new->name, (void *)new->start, (void *)new->end, tmp->name, (void *)tmp->start, (void *)tmp->end);
+		WARN_ON(1);
+		goto insert;
 	}
 }
 

  reply	other threads:[~2008-08-23 15:04 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-23 11:58 HPET regression in 2.6.26 versus 2.6.25 -- found another user with the same regression David Witbrodt
2008-08-23 13:36 ` Ingo Molnar
2008-08-23 15:03   ` Ingo Molnar [this message]
2008-08-23 17:51 ` Yinghai Lu
  -- strict thread matches above, loose matches on Subject: below --
2008-08-23 23:11 David Witbrodt
2008-08-23 23:09 David Witbrodt
2008-08-23 20:00 David Witbrodt
2008-08-23 20:13 ` Rufus & Azrael
2008-08-23 19:29 David Witbrodt
2008-08-23 16:44 David Witbrodt
2008-08-23 16:32 David Witbrodt
2008-08-23 15:42 David Witbrodt
2008-08-23 15:55 ` Ingo Molnar
2008-08-23 11:42 David Witbrodt
2008-08-23  2:25 David Witbrodt
2008-08-23  5:41 ` Yinghai Lu
2008-08-23  6:56   ` Yinghai Lu
2008-08-22  1:24 David Witbrodt
2008-08-21 16:53 David Witbrodt
2008-08-21 17:57 ` Yinghai Lu
2008-08-21 14:09 David Witbrodt
2008-08-21 15:33 ` Yinghai Lu
2008-08-21 13:33 David Witbrodt
2008-08-21  4:07 David Witbrodt
2008-08-21  6:42 ` Yinghai Lu
2008-08-21  7:04 ` Ilpo Järvinen
2008-08-21  2:48 David Witbrodt
2008-08-20 17:42 David Witbrodt
2008-08-20 17:58 ` Yinghai Lu
2008-08-21  2:02   ` Yinghai Lu
2008-08-20 16:44 David Witbrodt
2008-08-20 14:32 David Witbrodt
2008-08-20 14:49 ` Ingo Molnar
2008-08-20 14:08 David Witbrodt
2008-08-20  4:51 David Witbrodt
2008-08-20  5:21 ` Yinghai Lu
2008-08-20  7:51   ` Bill Fink
2008-08-20  8:02     ` Yinghai Lu
2008-08-20  9:15       ` Ingo Molnar
2008-08-20  9:31         ` Yinghai Lu
2008-08-20  9:36           ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080823150358.GA8579@elte.hu \
    --to=mingo@elte.hu \
    --cc=billfink@mindspring.com \
    --cc=dawitbro@sbcglobal.net \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=vgoyal@redhat.com \
    --cc=yhlu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).