From: David Miller <davem@davemloft.net>
To: agl@imperialviolet.org
Cc: netdev@vger.kernel.org, love_phil@emc.com
Subject: Re: [PATCH] tcp: fix tcp header size miscalculation when window scale is unused
Date: Sun, 24 Aug 2008 17:45:44 -0700 (PDT) [thread overview]
Message-ID: <20080824.174544.244704849.davem@davemloft.net> (raw)
In-Reply-To: <396556a20805301217k293e5718h6bbf02bfe069081@europa>
From: "Adam Langley" <agl@imperialviolet.org>
Date: Sun, 24 Aug 2008 10:40:23 -0700
> From: Philip Love <love_phil@emc.com>
>
> tcp: fix tcp header size miscalculation when window scale is unused
>
> The size of the TCP header is miscalculated when the window scale ends up being
> 0. Additionally, this can be induced by sending a SYN to a passive open port
> with a window scale option with value 0.
>
> Signed-off-by: Philip Love <love_phil@emc.com>
> Signed-off-by: Adam Langley <agl@imperialviolet.org>
Adam I really appreciate you're fixing up the patch for Philip, but
how in the world is he ever going to learn how to submit a patch
properly if you just do it for him?
I could have fixed it up too, but I pushed it back so that he learns
how to submit a patch correctly, and this will help him and the rest
of us in the future when he wants to submit other patches.
next prev parent reply other threads:[~2008-08-25 0:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-23 17:18 [PATCH] tcp: fix tcp header size miscalculation when window scale is unused Philip Love
2008-08-23 17:20 ` Adam Langley
2008-08-24 4:40 ` David Miller
2008-08-24 17:40 ` Adam Langley
2008-08-25 0:45 ` David Miller [this message]
2008-08-25 16:30 ` Phil Love
2008-08-25 21:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080824.174544.244704849.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=agl@imperialviolet.org \
--cc=love_phil@emc.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).