From: Alexey Dobriyan <adobriyan@gmail.com>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: kaber@trash.net, netfilter-devel@vger.kernel.org,
netdev@vger.kernel.org, containers@lists.linux-foundation.org
Subject: Re: [PATCH 20/38] netns ct: NOTRACK in netns
Date: Sun, 24 Aug 2008 14:43:13 +0400 [thread overview]
Message-ID: <20080824104313.GA3010@x200.localdomain> (raw)
In-Reply-To: <alpine.LNX.1.10.0808232034380.8996@fbirervta.pbzchgretzou.qr>
On Sat, Aug 23, 2008 at 08:35:07PM -0400, Jan Engelhardt wrote:
>
> On Friday 2008-08-22 07:30, adobriyan@gmail.com wrote:
> >
> >We wait for untracked ct refcount to drop to 1 back:
> >
> > /* wait until all references to nf_conntrack_untracked are dropped */
> > while (atomic_read(&nf_conntrack_untracked.ct_general.use) > 1)
> > schedule();
> >
> >Consequently it should be one per netns, otherwise netns A can prevent
> >netns B from stopping.
> >
>
> But nf_conntrack_cleanup is not per netns, is it?
That's because nf_conntrack_cleanup() is _code_.
If netns A actively uses NOTRACK, untracked ct refcount will be bumped.
And netns B which haven't used NOTRACK at all will wait for netns A to
stop using NOTRACK potentially indefinitely.
> At least I do not think it should be.
next prev parent reply other threads:[~2008-08-24 10:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-21 22:04 [PATCH 20/38] netns ct: NOTRACK in netns adobriyan
2008-08-21 23:06 ` Jan Engelhardt
2008-08-22 11:30 ` adobriyan
2008-08-24 0:35 ` Jan Engelhardt
2008-08-24 10:43 ` Alexey Dobriyan [this message]
2008-09-04 16:54 ` Patrick McHardy
2008-09-05 2:58 ` Alexey Dobriyan
2008-09-05 4:18 ` Jan Engelhardt
2008-09-05 11:33 ` Patrick McHardy
2008-09-05 11:54 ` Pablo Neira Ayuso
2008-09-05 12:25 ` Patrick McHardy
2008-09-05 13:08 ` Jan Engelhardt
2008-09-05 13:10 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080824104313.GA3010@x200.localdomain \
--to=adobriyan@gmail.com \
--cc=containers@lists.linux-foundation.org \
--cc=jengelh@medozas.de \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).