From: Al Viro <viro@ZenIV.linux.org.uk>
To: Arnaud Ebalard <arno@natisbad.org>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>
Subject: Re: [bisected] Weird sysctl regression
Date: Sun, 24 Aug 2008 12:54:24 +0100 [thread overview]
Message-ID: <20080824115424.GP28946@ZenIV.linux.org.uk> (raw)
In-Reply-To: <87od3jo2vn.fsf@natisbad.org>
On Sat, Aug 23, 2008 at 11:09:00PM +0200, Arnaud Ebalard wrote:
> Hi,
>
> Al Viro <viro@ZenIV.linux.org.uk> writes:
>
> > On Sat, Aug 23, 2008 at 07:13:49PM +0200, Arnaud Ebalard wrote:
> >
> >> I already tested 26.27-rc4 and even net-next-2.6 (recently released one
> >> based on rc4 with some bug fixes). Problem is still here.
> >
> > Just to make sure: that's rc4 without any additional patches?
>
> Sorry for the delay. Yes, no additional patches in both cases:
>
> - stock 2.6.27-rc4 from kernel.org
> - freshly cloned net-next-2.6 after David's announcement
Gyah... Dumb braino on my part. That sucker should've gone into the
global class, not the rotable stuff. See if that helps...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
diff --git a/net/ipv6/sysctl_net_ipv6.c b/net/ipv6/sysctl_net_ipv6.c
index e6dfaea..587f8f6 100644
--- a/net/ipv6/sysctl_net_ipv6.c
+++ b/net/ipv6/sysctl_net_ipv6.c
@@ -156,7 +156,7 @@ static struct ctl_table_header *ip6_base;
int ipv6_static_sysctl_register(void)
{
static struct ctl_table empty[1];
- ip6_base = register_net_sysctl_rotable(net_ipv6_ctl_path, empty);
+ ip6_base = register_sysctl_paths(net_ipv6_ctl_path, empty);
if (ip6_base == NULL)
return -ENOMEM;
return 0;
next prev parent reply other threads:[~2008-08-24 11:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-21 7:18 [bisected] Weird sysctl regression Arnaud Ebalard
2008-08-23 8:49 ` Al Viro
2008-08-23 16:03 ` Arnaud Ebalard
2008-08-23 17:02 ` Al Viro
2008-08-23 17:13 ` Arnaud Ebalard
2008-08-23 18:16 ` Al Viro
2008-08-23 21:09 ` Arnaud Ebalard
2008-08-24 11:54 ` Al Viro [this message]
2008-08-24 12:53 ` Arnaud Ebalard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080824115424.GP28946@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=arno@natisbad.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).