From: Jarek Poplawski <jarkao2@gmail.com>
To: jamal <hadi@cyberus.ca>
Cc: Alexander Duyck <alexander.duyck@gmail.com>,
David Miller <davem@davemloft.net>,
jeffrey.t.kirsher@intel.com, jeff@garzik.org,
netdev@vger.kernel.org, alexander.h.duyck@intel.com
Subject: Re: [PATCH 3/3] pkt_sched: restore multiqueue prio scheduler
Date: Sun, 24 Aug 2008 21:59:14 +0200 [thread overview]
Message-ID: <20080824195914.GA3461@ami.dom.local> (raw)
In-Reply-To: <20080824192734.GB3372@ami.dom.local>
On Sun, Aug 24, 2008 at 09:27:34PM +0200, Jarek Poplawski wrote:
> On Sun, Aug 24, 2008 at 09:19:05PM +0200, Jarek Poplawski wrote:
> ...
> > Jamal, maybe I miss something, but this could be like this only with
> > default pfifo_fast qdiscs, which really are per dev hwqueue. Other
> > qdiscs, including prio, are per device, so with prio, if a band with
> > the highest priority is blocked it would be requeued blocking other
> > bands (hwqueues in Alexander's case).
>
> And, actually, because of this, Alexander is right the prio_dequeue()
> can't work like this without any changes.
...And it looks like it's not only about prio with queue remapping.
Similar fixes are probably needed by default to any other qdiscs
implementing priorities, like htb etc!
Jarek P.
next prev parent reply other threads:[~2008-08-24 19:53 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-22 0:51 [PATCH 1/3] LRO: fix return code propogation Jeff Kirsher
2008-08-22 0:51 ` [PATCH 2/3] netlink: nal_parse_nested_compat was not parsing nested attributes Jeff Kirsher
2008-08-22 10:18 ` David Miller
2008-08-22 17:40 ` [PATCH 2/3] netlink: nla_parse_nested_compat " Duyck, Alexander H
2008-08-27 14:52 ` Thomas Graf
2008-08-27 18:09 ` Duyck, Alexander H
2008-08-22 0:51 ` [PATCH 3/3] pkt_sched: restore multiqueue prio scheduler Jeff Kirsher
2008-08-22 10:16 ` David Miller
2008-08-22 14:30 ` jamal
2008-08-22 22:19 ` Jarek Poplawski
2008-08-23 0:01 ` Alexander Duyck
2008-08-23 0:40 ` David Miller
2008-08-23 1:37 ` Alexander Duyck
2008-08-23 5:12 ` Herbert Xu
2008-08-23 6:35 ` Alexander Duyck
2008-08-23 7:07 ` Herbert Xu
2008-08-23 8:23 ` David Miller
2008-08-23 8:15 ` David Miller
2008-08-23 0:33 ` David Miller
2008-08-23 8:47 ` Jarek Poplawski
2008-08-23 16:31 ` Alexander Duyck
2008-08-23 16:49 ` jamal
2008-08-23 19:09 ` Alexander Duyck
2008-08-24 7:53 ` Jarek Poplawski
2008-08-24 13:39 ` jamal
2008-08-24 19:19 ` Jarek Poplawski
2008-08-24 19:27 ` Jarek Poplawski
2008-08-24 19:59 ` Jarek Poplawski [this message]
2008-08-24 20:18 ` Jarek Poplawski
2008-08-25 0:50 ` David Miller
2008-08-25 3:03 ` Alexander Duyck
2008-08-25 6:16 ` Jarek Poplawski
2008-08-25 9:36 ` Jarek Poplawski
2008-08-25 0:49 ` David Miller
2008-08-25 6:06 ` Jarek Poplawski
2008-08-25 7:48 ` David Miller
2008-08-25 7:57 ` Jarek Poplawski
2008-08-25 8:02 ` David Miller
2008-08-25 8:25 ` Jarek Poplawski
2008-08-25 8:35 ` Jarek Poplawski
2008-08-22 10:20 ` [PATCH 1/3] LRO: fix return code propogation David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080824195914.GA3461@ami.dom.local \
--to=jarkao2@gmail.com \
--cc=alexander.duyck@gmail.com \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=jeff@garzik.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).