netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ron Mercer <ron.mercer@qlogic.com>
To: David Miller <davem@davemloft.net>
Cc: jeff@garzik.org, Linux-Driver@qlogic.com, netdev@vger.kernel.org
Subject: Re: [RFC] New Qlogic 10Gb Ethernet driver for 2.6.28
Date: Mon, 25 Aug 2008 10:01:48 -0700	[thread overview]
Message-ID: <20080825170148.GA31059@susedev.qlogic.org> (raw)
In-Reply-To: <20080822.144343.231567307.davem@davemloft.net>

On Fri, Aug 22, 2008 at 02:43:43PM -0700, David Miller wrote:
> From: Ron Mercer <ron.mercer@qlogic.com>
> Date: Fri, 22 Aug 2008 10:46:26 -0700
> 
> > On Fri, Aug 22, 2008 at 02:42:52AM -0700, David Miller wrote:
> > > I also notice that this driver does not do:
> > > 
> > > 	skb_reserve(skb, NET_IP_ALIGN);
> > > 
> > > on RX packets to get the IP headers properly 4-byte aligned aligned
> > > after the ethernet header.
> > 
> > The chip currenly has problems with 2-byte aligned receive buffers.
> > It will be fixed in the next turn.
> 
> If the chip cannot handle this, you will need to copy into a properly
> aligned buffer.
> 
> Otherwise some RISC platforms will take unaligned access traps, which
> run extremely slowly, when 32-bit and larger members of the protocol
> headers are read by the networking stack.

I see your point.  I will add the re-alignment but would like to jump
over it for platforms that don't need it.  Is there a list somewhere of
the RISC platforms that take a trap on unaligned accesses?  Or better
yet, a list of those that don't?



  reply	other threads:[~2008-08-25 17:02 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-21 18:54 [RFC] New Qlogic 10Gb Ethernet driver for 2.6.28 Ron Mercer
2008-08-21 19:48 ` Ben Hutchings
2008-08-22  9:14   ` Jeff Garzik
2008-08-22 17:43     ` Ron Mercer
2008-08-22  9:22 ` Jeff Garzik
2008-08-22  9:42   ` David Miller
2008-08-22 17:46     ` Ron Mercer
2008-08-22 21:43       ` David Miller
2008-08-25 17:01         ` Ron Mercer [this message]
2008-08-25 21:05           ` David Miller
2008-08-26  9:36           ` Ben Hutchings
2008-08-22 17:42   ` Ron Mercer
2008-08-22 20:09 ` [RFC] qlge: " Ron Mercer
2008-08-22 20:21   ` [PATCH 1/6] [RFC] qlge: New Driver: Makefile and Kconfig changes Ron Mercer
2008-08-22 20:21   ` [PATCH 2/6] [RFC] qlge: New Driver: Adding main driver file qlge_main.c Ron Mercer
2008-08-26 11:24     ` Ben Hutchings
2008-08-26 16:51       ` Ron Mercer
2008-08-27 14:11       ` Ron Mercer
2008-08-22 20:21   ` [PATCH 3/6] [RFC] qlge: New Driver: Added management file qlge_mpi.c Ron Mercer
2008-08-22 20:21   ` [PATCH 4/6] [RFC] qlge: New Driver: Adding ethtool file qlge_ethtool.c Ron Mercer
2008-08-22 20:21   ` [PATCH 5/6] [RFC] qlge: New Driver: Adding driver header file qlge.h Ron Mercer
2008-08-26 11:00     ` Ben Hutchings
2008-08-22 20:21   ` [PATCH 6/6] [RFC] qlge: New Driver: Adding makefile Ron Mercer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080825170148.GA31059@susedev.qlogic.org \
    --to=ron.mercer@qlogic.com \
    --cc=Linux-Driver@qlogic.com \
    --cc=davem@davemloft.net \
    --cc=jeff@garzik.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).