Re: [PATCH] tcp FRTO: in-order-only "TCP proxy" fragility workaround

[Thomas Jarosch <thomas.jarosch@intra2net.com>]

[-- Attachment #1: Type: text/plain, Size: 1598 bytes --]

Forward mail. Upgrading to KDE 4.1.0/kdepim4 from KDE 3.5.9
enabled HTML emails by default and I didn't notice it before.

----------  Forwarded Message  ----------

Subject: Re: [PATCH] tcp FRTO: in-order-only "TCP proxy" fragility workaround
Date: Monday, 25. August 2008
From: Thomas Jarosch <thomas.jarosch@intra2net.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>

On Friday, 22. August 2008 23:18:44 Ilpo Järvinen wrote:
> In the meantime, can you check the attached patches. Besides the kernel
> patch, you need to build your own patched iproute2 as well to configure
> the features (ip tool among them is enough in case the build of some other
> part of the toolset fails like it did for me). I somewhat tested them, and
> the result seemed to be what I'd expect (I just forced RTOs with some
> netem heavy dropping and quickly glanced over the resulting packet
> patterns near RTO).

Your patches work fine.

I've noticed two small things:
1. Maybe it's a good idea to add a note above the tcp_use_frto() change
to explain that the value is negated. Took me a while to figure out
why there is no "!" in there :-)
2. Maybe rename the "features" option in iproute2 to "disable_features".
Then it would be more intuitive what it does.


btw: If you apply something to the iproute2 git tree,
I got a compiler error while testing the patch:

In file included from lnstat.c:40:
lnstat.h:28: error: field 'last_read' has incomplete type
lnstat.h:29: error: field 'interval' has incomplete type

Attached small patch fixes the issue.

Cheers,
Thomas


[-- Attachment #2: iproute2-fix-include-for-timeval.patch --]
[-- Type: text/x-patch, Size: 552 bytes --]

Fix this compile error:

In file included from lnstat.c:40:
lnstat.h:28: error: field 'last_read' has incomplete type
lnstat.h:29: error: field 'interval' has incomplete type

Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>

diff -u -r iproute2-2.6.25/misc/lnstat.h iproute2.timeval/misc/lnstat.h
--- iproute2-2.6.25/misc/lnstat.h	Thu Apr 17 19:12:54 2008
+++ iproute2.timeval/misc/lnstat.h	Mon Aug 25 17:48:33 2008
@@ -2,6 +2,7 @@
 #define _LNSTAT_H
 
 #include <limits.h>
+#include <sys/time.h>
 
 #define LNSTAT_VERSION "0.02 041002"