From: Jarek Poplawski <jarkao2@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH] pkt_sched: Fix dev_graft_qdisc() locking
Date: Tue, 26 Aug 2008 13:05:36 +0000 [thread overview]
Message-ID: <20080826130536.GC5991@ff.dom.local> (raw)
In-Reply-To: <E1KXxy1-0000kI-00@gondolin.me.apana.org.au>
On Tue, Aug 26, 2008 at 10:48:13PM +1000, Herbert Xu wrote:
> Jarek Poplawski <jarkao2@gmail.com> wrote:
> > pkt_sched: Fix dev_graft_qdisc() locking
> >
> > During dev_graft_qdisc() dev is deactivated, so qdisc_root_lock()
> > returns wrong lock of noop_qdisc instead of qdisc_sleeping.
> >
> >
> > Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
>
> Looks good to me!
>
> Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
>
BTW, I should've probably mention this lock doesn't probably
matter here much, after current precise deactivation.
Thanks,
Jarek P.
next prev parent reply other threads:[~2008-08-26 13:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-25 22:48 [PATCH] pkt_sched: Fix dev_graft_qdisc() locking Jarek Poplawski
2008-08-26 12:48 ` Herbert Xu
2008-08-26 13:05 ` Jarek Poplawski [this message]
2008-08-27 9:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080826130536.GC5991@ff.dom.local \
--to=jarkao2@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).