From: David Miller <davem@davemloft.net>
To: vladislav.yasevich@hp.com
Cc: eteo@redhat.com, netdev@vger.kernel.org, security@kernel.org,
linux-sctp@vger.kernel.org
Subject: Re: [PATCH 1/2] sctp: correct bounds check in sctp_setsockopt_auth_key
Date: Wed, 27 Aug 2008 16:09:15 -0700 (PDT) [thread overview]
Message-ID: <20080827.160915.57923023.davem@davemloft.net> (raw)
In-Reply-To: <12198674162757-git-send-email-vladislav.yasevich@hp.com>
From: Vlad Yasevich <vladislav.yasevich@hp.com>
Date: Wed, 27 Aug 2008 16:03:34 -0400
> The bonds check to prevent buffer overlflow was not exactly
> right. It still allowed overflow of up to 8 bytes which is
> sizeof(struct sctp_authkey).
>
> Since optlen is already checked against the size of that struct,
> we are guaranteed not to cause interger overflow either.
>
> Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Applied, and queued for -stable.
next prev parent reply other threads:[~2008-08-27 23:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <48B42ECA.7010800@redhat.com>
2008-08-27 20:03 ` [PATCH 0/2] sctp: additional overflow fixes Vlad Yasevich
2008-08-27 20:03 ` [PATCH 1/2] sctp: correct bounds check in sctp_setsockopt_auth_key Vlad Yasevich
2008-08-27 23:09 ` David Miller [this message]
2008-08-28 0:01 ` Eugene Teo
2008-08-27 20:03 ` [PATCH 2/2] sctp: fix random memory dereference with SCTP_HMAC_IDENT option Vlad Yasevich
2008-08-27 23:10 ` David Miller
2008-08-28 0:02 ` Eugene Teo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080827.160915.57923023.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eteo@redhat.com \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=security@kernel.org \
--cc=vladislav.yasevich@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).